Bugfixes: Theme at startup, Linux dead-code, Svelte render lint

- `theme.mode` now applies at every window's startup via `settings-applier.ts`, not just when the Themes section happens to mount. Restarting with light mode persisted on a dark-mode system used to start dark and flip when settings opened. The applier subscribes to `theme.mode` changes too, so the Themes section is now a pure UI shell.
- Gate `restricted_paths::reprobe_all_async` to `#[cfg(target_os = "macos")]` — its only caller, the `NSApplicationDidBecomeActive` observer, is already macOS-only, so the function is dead code on Linux and `#![deny(unused)]` was failing the Linux build.
- Add the canonical `eslint-disable-next-line @typescript-eslint/no-confusing-void-expression` comment on the two `{@render scanPhaseBody()}` lines in `TransferProgressDialog.svelte`. Same pattern as `DualPaneExplorer.svelte` — local snippets confuse the type-aware rule where prop `Snippet` ones don't.
- Tiny cleanup: wrap the two `() => void handleCancel(false)` arrow shorthands in `TransferProgressDialog.svelte` with braces. Not what was failing lint, but the void-in-shorthand pattern is a known footgun and the braces are clearer.

Author: vdavid

apps/desktop/src-tauri/src/restricted_paths/mod.rs

@@ -109,6 +109,13 @@ pub fn snapshot() -> Vec<String> {
 /// Re-probe every path in the restricted set with a cheap `read_dir`. Any
 /// path that now opens successfully is cleared. Runs on a blocking task —
 /// safe to call from the main thread (the observer block does so).
+///
+/// macOS-only because the only caller — the `NSApplicationDidBecomeActive`
+/// observer in `install_did_become_active_observer` below — is itself macOS
+/// only. Other platforms have no equivalent re-probe trigger today, so the
+/// function would just be dead code there (and `#![deny(unused)]` would fail
+/// the Linux build).
+#[cfg(target_os = "macos")]
 pub fn reprobe_all_async() {
     let paths_to_probe = {
         let guard = state().read().expect("restricted_paths state poisoned");

apps/desktop/src/lib/file-operations/transfer/TransferProgressDialog.svelte

@@ -855,7 +855,9 @@
     titleId="progress-dialog-title"
     onkeydown={handleKeydown}
     dialogId="transfer-progress"
-    onclose={() => void handleCancel(false)}
+    onclose={() => {
+        void handleCancel(false)
+    }}
     containerStyle="width: 500px"
 >
     {#snippet title()}
@@ -877,11 +879,17 @@
         {/if}
 
         <div class="scan-wait-section">
+<!-- eslint-disable-next-line @typescript-eslint/no-confusing-void-expression -- Svelte {@render} syntax -->
             {@render scanPhaseBody()}
         </div>
 
         <div class="button-row">
-            <Button variant="secondary" onclick={() => void handleCancel(false)}>Cancel</Button>
+            <Button
+                variant="secondary"
+                onclick={() => {
+                    void handleCancel(false)
+                }}>Cancel</Button
+            >
         </div>
     {:else if !isDeleteOrTrash && conflictEvent}
         <!-- Conflict resolution (copy/move only) -->
@@ -1027,7 +1035,8 @@
         {#if phase === 'scanning'}
             <!-- Scanning phase: tallies, throughput, optional progress bar, current dir/file. -->
             <div class="scan-wait-section">
-                {@render scanPhaseBody()}
+    <!-- eslint-disable-next-line @typescript-eslint/no-confusing-void-expression -- Svelte {@render} syntax -->
+            {@render scanPhaseBody()}
             </div>
         {:else}
             <!-- Dual progress bars (size + count) for the active phase. -->

apps/desktop/src/lib/settings/sections/ThemesSection.svelte

@@ -1,13 +1,9 @@
 <script lang="ts">
-    import { onMount, onDestroy } from 'svelte'
     import SettingsSection from '../components/SettingsSection.svelte'
     import SettingRow from '../components/SettingRow.svelte'
     import SettingToggleGroup from '../components/SettingToggleGroup.svelte'
-    import { getSettingDefinition, onSpecificSettingChange, getSetting } from '$lib/settings'
+    import { getSettingDefinition } from '$lib/settings'
     import { createShouldShow } from '$lib/settings/settings-search'
-    import { getAppLogger } from '$lib/logging/logger'
-
-    const log = getAppLogger('settings')
 
     interface Props {
         searchQuery: string
@@ -19,38 +15,10 @@
 
     const themeModeDef = getSettingDefinition('theme.mode') ?? { label: '', description: '' }
 
-    let unsubscribe: (() => void) | undefined
-
-    async function applyTheme(mode: string) {
-        log.debug('Applying theme: {mode}', { mode })
-        try {
-            const { setTheme } = await import('@tauri-apps/api/app')
-            if (mode === 'system') {
-                // Setting null lets Tauri follow system preference
-                await setTheme(null)
-            } else {
-                await setTheme(mode as 'light' | 'dark')
-            }
-            log.info('Theme applied: {mode}', { mode })
-        } catch (error) {
-            log.error('Failed to apply theme: {error}', { error })
-        }
-    }
-
-    onMount(() => {
-        // Apply current theme on mount (in case it changed while settings were closed)
-        const currentTheme = getSetting('theme.mode')
-        void applyTheme(currentTheme)
-
-        // Listen for theme changes
-        unsubscribe = onSpecificSettingChange('theme.mode', (_id, value) => {
-            void applyTheme(value)
-        })
-    })
-
-    onDestroy(() => {
-        unsubscribe?.()
-    })
+    // Theme application lives in `settings-applier.ts` — it runs at every window's
+    // startup, so the persisted choice takes effect on cold launches and not just
+    // when this section happens to mount. Toggling the radio fires `setSetting`,
+    // which the applier subscribes to.
 </script>
 
 <SettingsSection title="Themes">

apps/desktop/src/lib/settings/settings-applier.ts

@@ -10,6 +10,7 @@ import {
   type UiDensity,
   type SizeColorsPalette,
   type DateColorsPalette,
+  type ThemeMode,
 } from '$lib/settings'
 import { getAppLogger, setVerboseLogging } from '$lib/logging/logger'
 import {
@@ -98,6 +99,24 @@ async function applyBackendSettings(): Promise<void> {
   })
 }
 
+/**
+ * Applies the persisted `theme.mode` setting via Tauri's per-app theme API.
+ * Loaded dynamically so we don't pay the import cost on every startup of
+ * non-Tauri contexts (tests, SSR) where the API isn't available.
+ *
+ * `'system'` is signaled by passing `null`, which tells Tauri to follow the
+ * OS appearance.
+ */
+async function applyTheme(mode: ThemeMode): Promise<void> {
+  try {
+    const { setTheme } = await import('@tauri-apps/api/app')
+    await setTheme(mode === 'system' ? null : mode)
+    log.debug('Applied theme: {mode}', { mode })
+  } catch (error) {
+    log.error('Failed to apply theme: {error}', { error })
+  }
+}
+
 /**
  * Applies all settings that affect the UI.
  */
@@ -112,6 +131,10 @@ function applyAllSettings(): void {
   // Date age color palette
   applyDateColors(getSetting('appearance.dateColors'))
 
+  // Theme (light / dark / system). Must run at startup or windows that open
+  // before the user touches Settings will flash the wrong theme.
+  void applyTheme(getSetting('theme.mode'))
+
   // Backend settings (async, fire-and-forget for startup)
   void applyBackendSettings()
 
@@ -162,6 +185,10 @@ function handleSettingChange(id: string, value: unknown): void {
     applyDateColors(value as DateColorsPalette)
     return
   }
+  if (id === 'theme.mode') {
+    void applyTheme(value as ThemeMode)
+    return
+  }
   if (id === 'advanced.maxLogStorageMb') {
     applyMaxLogStorageMb(value as number)
     return