Skip to content

Commit fe5569c

Browse files
committed
Deps: Bump smb2 to 0.11.3 (srvsvc fragment reassembly)
- `smb2 0.11.3` reassembles a `NetShareEnum` srvsvc reply split across multiple DCE/RPC fragments and follows `STATUS_BUFFER_OVERFLOW`, so older Samba / NAS servers with many shares or long comments now enumerate over the pure-Rust path instead of triggering the CLI fallback. - Adds `smb-consumer-50shares` to the `core` SMB container set (`start.sh`) and the integration check's wait-list, so the new end-to-end share-enumeration test has its fixture up. - The matching validation test lands with `smb_client.rs` in the follow-up security commit (same file as the fallback rewrite).
1 parent a787551 commit fe5569c

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/desktop/src-tauri/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ mdns-sd = { version = "0.19", features = ["logging"] }
190190
# SMB2/3 protocol client for share enumeration (pure Rust, pipelined I/O).
191191
# When bumping: also re-vendor the test containers per
192192
# apps/desktop/test/smb-servers/.compose/VENDORED.md
193-
smb2 = { version = "0.11.2", features = ["serde"] }
193+
smb2 = { version = "0.11.3", features = ["serde"] }
194194
# NFD normalization for APFS collation and SMB path normalization
195195
unicode-normalization = "0.1"
196196
# Percent-decoding for MCP resource URI query strings (cross-platform).

apps/desktop/test/smb-servers/start.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ case "$mode" in
4141
echo "Starting core SMB servers (auth scenarios + edge cases)..."
4242
services=(smb-consumer-guest smb-consumer-auth smb-consumer-both \
4343
smb-consumer-readonly smb-consumer-flaky smb-consumer-slow \
44-
smb-consumer-maxreadsize)
44+
smb-consumer-maxreadsize smb-consumer-50shares)
4545
;;
4646
all)
4747
echo "Starting all SMB servers (15 containers)..."

scripts/check/checks/desktop-rust-integration-tests.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func RunRustIntegrationTests(ctx *CheckContext) (CheckResult, error) {
5353
"smb-consumer-readonly",
5454
"smb-consumer-flaky",
5555
"smb-consumer-slow",
56+
"smb-consumer-50shares",
5657
}
5758
if err := waitForSmbContainers(expected, 120*time.Second); err != nil {
5859
return CheckResult{}, err

0 commit comments

Comments
 (0)