Introduce ModalDialog

- Now all soft modals use the same dialog component
- All are draggable
- Saved some code on the duplicated event handlers
- Ensured MCP server knows about _all_ the dialogs we have (safety added with TypeScript)
- Fixed a closing bug in one of the more obscure dialogs

Author: vdavid

apps/desktop/coverage-allowlist.json

@@ -2,7 +2,8 @@
     "$comment": "Files listed here are exempt from coverage thresholds. Each entry should include a reason. Remove entries as you add tests.",
     "files": {
         "ui/AlertDialog.svelte": { "reason": "Simple UI modal for informational messages" },
-        "ui/DraggableDialog.svelte": { "reason": "Shared draggable dialog wrapper, depends on DOM APIs" },
+        "ui/dialog-registry.ts": { "reason": "Pure constant and type definition, no logic to test" },
+        "ui/ModalDialog.svelte": { "reason": "Shared modal dialog wrapper, depends on DOM APIs and Tauri commands" },
         "updates/UpdateNotification.svelte": { "reason": "UI component, needs component testing" },
         "app-status-store.ts": { "reason": "Depends on Tauri APIs" },
         "benchmark.ts": { "reason": "Dev tooling, not critical path" },

apps/desktop/src-tauri/src/lib.rs

@@ -368,6 +368,7 @@ pub fn run() {
             mcp::pane_state::update_focused_pane,
             mcp::dialog_state::notify_dialog_opened,
             mcp::dialog_state::notify_dialog_closed,
+            mcp::dialog_state::register_known_dialogs,
             mcp::settings_state::mcp_update_settings_state,
             mcp::settings_state::mcp_update_settings_open,
             mcp::settings_state::mcp_update_settings_section,

apps/desktop/src-tauri/src/mcp/dialog_state.rs

@@ -1,24 +1,38 @@
 //! Soft dialog tracking for MCP context tools.
 //!
-//! Tracks in-page overlay dialogs (about, license, copy-confirmation, mkdir-confirmation).
+//! Tracks in-page overlay dialogs (about, license, copy-confirmation, etc.).
 //! Window-based dialogs (settings, file viewers) are derived from Tauri's window manager
 //! in resources.rs — no manual tracking needed for those.
+//!
+//! The frontend registers all known soft dialog IDs at startup via
+//! `register_known_dialogs`, so the MCP "available dialogs" resource
+//! stays in sync with the actual Svelte components automatically.
 
 use std::collections::HashSet;
 use std::sync::RwLock;
+use serde::Deserialize;
 use tauri::{AppHandle, Manager};
 
-/// Tracks which soft (overlay) dialogs are currently open.
-/// Uses a simple set of dialog type strings.
+/// A dialog type registered by the frontend at startup.
+#[derive(Debug, Clone, Deserialize)]
+pub struct KnownDialog {
+    pub id: String,
+    pub description: Option<String>,
+}
+
+/// Tracks which soft (overlay) dialogs are currently open,
+/// and which dialog types are known (registered at startup).
 #[derive(Debug, Default)]
 pub struct SoftDialogTracker {
     open: RwLock<HashSet<String>>,
+    known: RwLock<Vec<KnownDialog>>,
 }
 
 impl SoftDialogTracker {
     pub fn new() -> Self {
         Self {
             open: RwLock::new(HashSet::new()),
+            known: RwLock::new(Vec::new()),
         }
     }
 
@@ -33,6 +47,14 @@ impl SoftDialogTracker {
     pub fn get_open_types(&self) -> Vec<String> {
         self.open.read().unwrap().iter().cloned().collect()
     }
+
+    pub fn register_known(&self, dialogs: Vec<KnownDialog>) {
+        *self.known.write().unwrap() = dialogs;
+    }
+
+    pub fn get_known_dialogs(&self) -> Vec<KnownDialog> {
+        self.known.read().unwrap().clone()
+    }
 }
 
 /// Tauri command: frontend notifies that a soft dialog opened.
@@ -51,6 +73,14 @@ pub fn notify_dialog_closed(app: AppHandle, dialog_type: String) {
     }
 }
 
+/// Tauri command: frontend registers all known soft dialog types at startup.
+#[tauri::command]
+pub fn register_known_dialogs(app: AppHandle, dialogs: Vec<KnownDialog>) {
+    if let Some(tracker) = app.try_state::<SoftDialogTracker>() {
+        tracker.register_known(dialogs);
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -87,4 +117,41 @@ mod tests {
         tracker.close("nonexistent"); // Should not panic
         assert!(tracker.get_open_types().is_empty());
     }
+
+    #[test]
+    fn test_register_known_dialogs() {
+        let tracker = SoftDialogTracker::new();
+        assert!(tracker.get_known_dialogs().is_empty());
+
+        let dialogs = vec![
+            KnownDialog { id: "about".to_string(), description: None },
+            KnownDialog { id: "alert".to_string(), description: None },
+            KnownDialog {
+                id: "copy-confirmation".to_string(),
+                description: Some("Opened by the copy tool".to_string()),
+            },
+        ];
+        tracker.register_known(dialogs);
+
+        let known = tracker.get_known_dialogs();
+        assert_eq!(known.len(), 3);
+        assert_eq!(known[0].id, "about");
+        assert_eq!(known[2].description.as_deref(), Some("Opened by the copy tool"));
+    }
+
+    #[test]
+    fn test_register_known_replaces_previous() {
+        let tracker = SoftDialogTracker::new();
+
+        tracker.register_known(vec![
+            KnownDialog { id: "about".to_string(), description: None },
+        ]);
+        assert_eq!(tracker.get_known_dialogs().len(), 1);
+
+        tracker.register_known(vec![
+            KnownDialog { id: "about".to_string(), description: None },
+            KnownDialog { id: "alert".to_string(), description: None },
+        ]);
+        assert_eq!(tracker.get_known_dialogs().len(), 2);
+    }
 }

apps/desktop/src-tauri/src/mcp/resources.rs

@@ -181,6 +181,31 @@ fn extract_viewer_path<R: Runtime>(window: &WebviewWindow<R>) -> Option<String>
         .map(|(_, value)| value.into_owned())
 }
 
+/// Build YAML for the "available dialogs" resource.
+/// Combines window-based types (hardcoded, stable) with soft dialog types
+/// registered by the frontend at startup.
+fn build_available_dialogs_yaml<R: Runtime>(app: &tauri::AppHandle<R>) -> String {
+    let mut yaml = String::new();
+
+    // Window-based dialog types (managed on the Rust side)
+    yaml.push_str("- type: settings\n  sections: [general, appearance, shortcuts, advanced]\n");
+    yaml.push_str(
+        "- type: file-viewer\n  description: Opens for file under cursor, or specify path. Multiple can be open.\n",
+    );
+
+    // Soft dialog types (registered by the frontend)
+    if let Some(tracker) = app.try_state::<SoftDialogTracker>() {
+        for dialog in tracker.get_known_dialogs() {
+            yaml.push_str(&format!("- type: {}\n", dialog.id));
+            if let Some(ref desc) = dialog.description {
+                yaml.push_str(&format!("  description: {}\n", desc));
+            }
+        }
+    }
+
+    yaml
+}
+
 /// Read a resource by URI.
 pub fn read_resource<R: Runtime>(app: &tauri::AppHandle<R>, uri: &str) -> Result<ResourceContent, String> {
     let (content, mime_type) = match uri {
@@ -260,17 +285,8 @@ pub fn read_resource<R: Runtime>(app: &tauri::AppHandle<R>, uri: &str) -> Result
             (yaml, "text/yaml")
         }
         "cmdr://dialogs/available" => {
-            let yaml = r#"- type: settings
-  sections: [general, appearance, shortcuts, advanced]
-- type: file-viewer
-  description: Opens for file under cursor, or specify path. Multiple can be open.
-- type: about
-- type: copy-confirmation
-  description: Opened by the copy tool, not directly. Can only be closed.
-- type: mkdir-confirmation
-  description: Opened by the mkdir tool, not directly. Can only be closed.
-"#;
-            (yaml.to_string(), "text/yaml")
+            let yaml = build_available_dialogs_yaml(app);
+            (yaml, "text/yaml")
         }
         _ => return Err(format!("Unknown resource URI: {}", uri)),
     };

apps/desktop/src/app.css

@@ -45,7 +45,6 @@
     --color-error: #d32f2f;
     --color-error-bg: #fef2f2;
     --color-error-border: #fecaca;
-    --color-error-text: #b91c1c;
     --color-warning: #e65100;
     --color-warning-bg: rgba(230, 81, 0, 0.1);
 
@@ -107,7 +106,6 @@
         --color-error: #f44336;
         --color-error-bg: #450a0a;
         --color-error-border: #7f1d1d;
-        --color-error-text: #fca5a5;
         --color-warning: #f5a623;
         --color-warning-bg: rgba(245, 166, 35, 0.15);
 

apps/desktop/src/lib/file-operations/copy/CopyDialog.svelte

@@ -10,8 +10,6 @@
         onScanPreviewError,
         onScanPreviewCancelled,
         scanVolumeForConflicts,
-        notifyDialogOpened,
-        notifyDialogClosed,
         type VolumeSpaceInfo,
         type VolumeConflictInfo,
         type SourceItemInput,
@@ -20,7 +18,7 @@
     import type { VolumeInfo, SortColumn, SortOrder, ConflictResolution } from '$lib/file-explorer/types'
     import { getSetting } from '$lib/settings'
     import DirectionIndicator from './DirectionIndicator.svelte'
-    import DraggableDialog from '$lib/ui/DraggableDialog.svelte'
+    import ModalDialog from '$lib/ui/ModalDialog.svelte'
     import { generateTitle } from './copy-dialog-utils'
     import { getAppLogger } from '$lib/logger'
 
@@ -220,9 +218,6 @@
     }
 
     onMount(async () => {
-        // Track dialog open state for MCP
-        void notifyDialogOpened('copy-confirmation')
-
         // Focus and select the path input
         await tick()
         pathInputRef?.focus()
@@ -236,9 +231,6 @@
     })
 
     onDestroy(() => {
-        // Track dialog close state for MCP
-        void notifyDialogClosed('copy-confirmation')
-
         // Cancel scan preview if still running
         if (previewId && isScanning) {
             void cancelScanPreview(previewId)
@@ -261,26 +253,27 @@
     }
 
     function handleKeydown(event: KeyboardEvent) {
-        event.stopPropagation()
-        if (event.key === 'Escape') {
-            handleCancel()
-        } else if (event.key === 'Enter') {
+        if (event.key === 'Enter') {
             handleConfirm()
         }
     }
 
     function handleInputKeydown(event: KeyboardEvent) {
-        event.stopPropagation()
-        if (event.key === 'Escape') {
-            handleCancel()
-        } else if (event.key === 'Enter') {
+        if (event.key === 'Enter') {
             event.preventDefault()
+            event.stopPropagation()
             handleConfirm()
         }
     }
 </script>
 
-<DraggableDialog titleId="dialog-title" onkeydown={handleKeydown}>
+<ModalDialog
+    titleId="dialog-title"
+    onkeydown={handleKeydown}
+    dialogId="copy-confirmation"
+    onclose={handleCancel}
+    containerStyle="min-width: 420px; max-width: 500px"
+>
     {#snippet title()}{dialogTitle}{/snippet}
 
     <!-- Direction indicator -->
@@ -368,7 +361,7 @@
         <button class="secondary" onclick={handleCancel}>Cancel</button>
         <button class="primary" onclick={handleConfirm}>Copy</button>
     </div>
-</DraggableDialog>
+</ModalDialog>
 
 <style>
     .volume-selector {