Skip to content

Commit 692a1be

Browse files
authored
fix: remove rimraf dependency (#529)
We don't need this anymore. Also the cli would fail because `rimraf` was a devDependency.
1 parent eb32460 commit 692a1be

5 files changed

Lines changed: 8 additions & 119 deletions

File tree

package-lock.json

Lines changed: 0 additions & 107 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@
119119
"redis": "^3.1.1",
120120
"remark-parse": "^11.0.0",
121121
"remark-prism": "^1.3.6",
122-
"rimraf": "^6.0.1",
123122
"rxjs": "^7.8.2",
124123
"saslprep": "^1.0.3",
125124
"semver": "^7.5.2",

src/cli.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
import { join, dirname, relative, isAbsolute, sep } from 'path';
44
import { promises, statSync, lstatSync } from 'graceful-fs';
5-
const { copyFile, mkdir } = promises;
6-
const rimraf = require('rimraf');
5+
const { copyFile, mkdir, rm } = promises;
76
import { nodeFileTrace } from './node-file-trace';
87
import { NodeFileTraceReasons } from './types';
98

@@ -62,7 +61,7 @@ async function cli(
6261
}
6362
}
6463
} else if (action === 'build') {
65-
rimraf.sync(join(cwd, outputDir));
64+
await rm(join(cwd, outputDir), { recursive: true, force: true });
6665
for (const f of allFiles) {
6766
const src = join(cwd, f);
6867
const dest = join(cwd, outputDir, f);

test/ecmascript.test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
1-
const { promises, mkdirSync } = require('fs');
1+
const { promises, mkdirSync, rmSync } = require('fs');
22
const path = require('path');
33
const { nodeFileTrace } = require('../out/node-file-trace');
44
const os = require('os');
5-
const rimraf = require('rimraf');
65
const { writeFile } = promises;
76

87
const randomTmpId = Math.random().toString().slice(2);
98
const tmpdir = path.resolve(
109
os.tmpdir(),
1110
`node-file-trace-ecmascript${randomTmpId}`,
1211
);
13-
rimraf.sync(tmpdir);
12+
rmSync(tmpdir, { recursive: true, force: true });
1413
mkdirSync(tmpdir);
1514
console.log('created directory ' + tmpdir);
1615

test/integration.test.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ const { promises, readdirSync, mkdirSync } = require('fs');
22
const path = require('path');
33
const { nodeFileTrace } = require('../out/node-file-trace');
44
const os = require('os');
5-
const rimraf = require('rimraf');
6-
const { readFile, writeFile, readlink, symlink, copyFile } = promises;
5+
const { readFile, writeFile, readlink, symlink, copyFile, rm } = promises;
76
const { fork, exec: execOrig } = require('child_process');
87

98
const exec = require('util').promisify(execOrig);
@@ -53,7 +52,7 @@ for (const integrationTest of filteredTestsToRun) {
5352
os.tmpdir(),
5453
`node-file-trace-${integrationTest}-${rand}`,
5554
);
56-
rimraf.sync(tmpdir);
55+
await rm(tmpdir, { recursive: true, force: true });
5756
mkdirSync(tmpdir);
5857
await copyFile(
5958
path.join(integrationDir, integrationTest),
@@ -87,7 +86,7 @@ for (const integrationTest of filteredTestsToRun) {
8786
);
8887
// warnings.forEach(warning => console.warn(warning));
8988
const tmpdir = path.resolve(os.tmpdir(), `node-file-trace-${rand}`);
90-
rimraf.sync(tmpdir);
89+
await rm(tmpdir, { recursive: true, force: true });
9190
mkdirSync(tmpdir);
9291

9392
await Promise.all(
@@ -118,7 +117,7 @@ for (const integrationTest of filteredTestsToRun) {
118117
});
119118
const code = await new Promise((resolve) => ps.on('close', resolve));
120119
expect(code).toBe(fails ? 1 : 0);
121-
rimraf.sync(tmpdir);
120+
await rm(tmpdir, { recursive: true, force: true });
122121

123122
// TODO: ensure analysis cache is safe for below case
124123
// seems this fails with cache since < 0.14.0

0 commit comments

Comments
 (0)