Skip to content

Commit a6d2548

Browse files
authored
fix: allow overriding app.kubernetes.io/version (#185)
* fix: allow overriding app.kubernetes.io/version * Update Chart.yaml * Bump verdaccio version to 4.31.0
1 parent e024777 commit a6d2548

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ and their default values.
9090
| `image.pullPolicy` | Image pull policy | `IfNotPresent` |
9191
| `image.pullSecrets` | Image pull secrets | `[]` |
9292
| `image.repository` | Verdaccio container image repository | `verdaccio/verdaccio` |
93-
| `image.tag` | Verdaccio container image tag | `5.21.1` |
93+
| `image.tag` | Verdaccio container image tag. Also used as `app.kubernetes.io/version` label when set | defaults to `appVersion` in Chart.yaml |
9494
| `nodeSelector` | Node labels for pod assignment | `{}` |
9595
| `tolerations` | List of node taints to tolerate | `[]` |
9696
| `persistence.accessMode` | PVC Access Mode for Verdaccio volume | `ReadWriteOnce` |

charts/verdaccio/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v2
22
description: A lightweight private node.js proxy registry
33
name: verdaccio
4-
version: 4.30.0
4+
version: 4.31.0
55
appVersion: 6.2.3
66
home: https://verdaccio.org
77
icon: https://cdn.verdaccio.dev/logos/default.png

charts/verdaccio/templates/_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Common labels
3838
helm.sh/chart: {{ include "verdaccio.chart" . }}
3939
{{ include "verdaccio.selectorLabels" . }}
4040
{{- if .Chart.AppVersion }}
41-
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
41+
app.kubernetes.io/version: {{ .Values.image.tag | default .Chart.AppVersion | quote }}
4242
{{- end }}
4343
app.kubernetes.io/managed-by: {{ .Release.Service }}
4444
app: {{ include "verdaccio.fullname" . }}

0 commit comments

Comments
 (0)