Skip to content

Commit 04fccb8

Browse files
mlucoolsergiohgz
authored andcommitted
fix: fixes for storage plugin types per code review (#59)
1 parent b032e8c commit 04fccb8

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

core/types/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ type StringValue = string | void | null;
339339
max_body_size?: string;
340340
notifications?: Notifications;
341341
middlewares?: any;
342-
storage_filters?: any;
342+
filters?: any;
343343
checkSecretKey(token: string): string;
344344
getMatchedPackagesSpec(storage: string): PackageAccess | void;
345345
[key: string]: any;
@@ -442,6 +442,6 @@ type StringValue = string | void | null;
442442
}
443443

444444
interface IPluginStorageFilter<T> extends IPlugin<T> {
445-
filter_metadata(packageInfo: Package, cb: Callback): void;
445+
filter_metadata(packageInfo: Package): Promise<Package>;
446446
}
447447
}

core/types/src/flow/types.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ declare interface verdaccio$Config {
332332
max_body_size?: string;
333333
notifications?: verdaccio$Notifications;
334334
middlewares?: any;
335-
storage_filters?: any;
335+
filters?: any;
336336
checkSecretKey(token: string): string;
337337
getMatchedPackagesSpec(storage: string): verdaccio$PackageAccess | void;
338338
[key: string]: any;
@@ -409,7 +409,7 @@ declare interface verdaccio$IBasicAuth {
409409

410410
declare interface verdaccio$IPlugin {
411411
version?: string;
412-
close(): void;
412+
// Optional: close(): void;
413413
}
414414

415415
declare type verdaccio$PluginOptions = {
@@ -431,7 +431,7 @@ declare interface verdaccio$IPluginMiddleware extends verdaccio$IPlugin {
431431
}
432432

433433
declare interface verdaccio$IPluginStorageFilter extends verdaccio$IPlugin {
434-
filter_metadata(packageInfo: verdaccio$Package, cb: verdaccio$Callback): void;
434+
filter_metadata(packageInfo: verdaccio$Package): Promise<verdaccio$Package>;
435435
}
436436

437437
declare module "@verdaccio/local-storage" {

0 commit comments

Comments
 (0)