fix: missing error code

Author: @jotadeveloper

plugins/local-storage/.npmignore

@@ -18,4 +18,8 @@ test/
 *.tmp-*
 _storage/
 circle.yml
-travis.yml
+travis.yml
+*.md
+coverage/
+jest.config.js
+jestEnvironment.js

plugins/local-storage/package-lock.json

@@ -14,7 +14,7 @@
     "@verdaccio/file-locking": "^0.0.5",
     "@verdaccio/streams": "^0.0.2",
     "async": "2.5.0",
-    "http-errors": "1.4.0",
+    "http-errors": "1.6.2",
     "lodash": "4.17.4",
     "mkdirp": "0.5.1"
   },

plugins/local-storage/package.json

@@ -5,7 +5,7 @@ import mkdirp from 'mkdirp';
 import fs from 'fs';
 import rm from 'rmdir-sync';
 import type {ILocalFS, Logger} from '@verdaccio/types';
-import LocalFS from '../local-fs';
+import LocalFS, {fileExist} from '../local-fs';
 
 let localFs: ILocalFS;
 let localTempStorage: string;
@@ -75,6 +75,14 @@ describe('Local FS test', ()=> {
     });
   });
 
+  test('createJSON() fails by fileExist', (done) => {
+    localFs.createJSON(path.join(localTempStorage, 'package5'), '{data:6}', (err)=> {
+      expect(err).not.toBeNull();
+      expect(err.code).toBe(fileExist);
+      done();
+    });
+  });
+
   test('deleteJSON()', (done) => {
     localFs.deleteJSON(path.join(localTempStorage, 'package5'), (err)=> {
       expect(err).toBeNull();

plugins/local-storage/src/___tests___/local-fs.test.js

@@ -51,10 +51,11 @@ import type {ILocalData, ILocalFS, StorageList, LocalStorage, Logger, Config} fr
    * @return {Error|*}
    */
   remove(name: string) {
-    const i = this.data.list.indexOf(name);
-    if (i !== -1) {
-      this.data.list.splice(i, 1);
+    const pkgName = this.get().indexOf(name);
+    if (pkgName !== -1) {
+      this.data.list.splice(pkgName, 1);
     }
+
     return this.sync();
   }
 

plugins/local-storage/src/local-data.js

@@ -11,11 +11,13 @@ import {UploadTarball, ReadTarball} from '@verdaccio/streams';
 import {unlockFile, readFile} from '@verdaccio/file-locking';
 import type {ILocalFS, Callback, Logger} from '@verdaccio/types';
 
-const fileExist: string = 'EEXISTS';
-const noSuchFile: string = 'ENOENT';
+export const fileExist: string = 'EEXISTS';
+export const noSuchFile: string = 'ENOENT';
 
 const fSError = function(message: string): HttpError {
   const err: HttpError = createError(409, message);
+  err.code = message;
+
   return err;
 };