Skip to content

Commit ee442a0

Browse files
n4bb12juanpicado
authored andcommitted
feat: improve auth callback TS types (#225)
* Improve auth callback TS types Adds a bit more validation for auth callbacks. See https://verdaccio.org/docs/en/dev-plugins#callback * 459:79 error Insert `;` prettier/prettier
1 parent 00b66af commit ee442a0

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

core/types/index.d.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -456,15 +456,17 @@ declare module '@verdaccio/types' {
456456
version?: string;
457457
}
458458

459+
type AuthCallback = (error: string | null, groups: string[] | false) => void;
460+
459461
interface IPluginAuth<T> extends IPlugin<T> {
460-
authenticate(user: string, password: string, cb: Callback): void;
461-
adduser?(user: string, password: string, cb: Callback): void;
462-
changePassword?(user: string, password: string, newPassword: string, cb: Callback): void;
463-
allow_access?(user: RemoteUser, pkg: T & PackageAccess, cb: Callback): void;
464-
allow_publish?(user: RemoteUser, pkg: T & PackageAccess, cb: Callback): void;
465-
allow_access?(user: RemoteUser, pkg: AllowAccess & PackageAccess, cb: Callback): void;
466-
allow_publish?(user: RemoteUser, pkg: AllowAccess & PackageAccess, cb: Callback): void;
467-
allow_unpublish?(user: RemoteUser, pkg: AllowAccess & PackageAccess, cb: Callback): void;
462+
authenticate(user: string, password: string, cb: AuthCallback): void;
463+
adduser?(user: string, password: string, cb: AuthCallback): void;
464+
changePassword?(user: string, password: string, newPassword: string, cb: AuthCallback): void;
465+
allow_access?(user: RemoteUser, pkg: T & PackageAccess, cb: AuthCallback): void;
466+
allow_publish?(user: RemoteUser, pkg: T & PackageAccess, cb: AuthCallback): void;
467+
allow_access?(user: RemoteUser, pkg: AllowAccess & PackageAccess, cb: AuthCallback): void;
468+
allow_publish?(user: RemoteUser, pkg: AllowAccess & PackageAccess, cb: AuthCallback): void;
469+
allow_unpublish?(user: RemoteUser, pkg: AllowAccess & PackageAccess, cb: AuthCallback): void;
468470
apiJWTmiddleware?(helpers: any): Function;
469471
}
470472

0 commit comments

Comments
 (0)