feat: local database method are async

Author: @jotadeveloper

plugins/memory/package.json

@@ -23,7 +23,7 @@
     "@commitlint/cli": "6.0.2",
     "@commitlint/config-conventional": "6.0.4",
     "@commitlint/travis-cli": "6.0.2",
-    "@verdaccio/types": "0.2.4",
+    "@verdaccio/types": "2.1.0",
     "babel-cli": "6.26.0",
     "babel-core": "6.26.0",
     "babel-eslint": "8.2.3",

plugins/memory/src/local-memory.js

@@ -1,7 +1,7 @@
 // @flow
 
 import MemoryHandler from './memory-handler';
-import type { Logger } from '@verdaccio/types';
+import type { Logger, Callback } from '@verdaccio/types';
 import type { ILocalData } from '@verdaccio/local-storage';
 
 export type ConfigMemory = { limit?: number };
@@ -31,29 +31,33 @@ class LocalMemory implements ILocalData {
     this.data.secret = secret;
   }
 
-  add(name: string) {
+  add(name: string, cb: Callback) {
     const { list } = this.data;
 
     if (list.length < this.limit) {
       if (list.indexOf(name) === -1) {
         list.push(name);
       }
+      cb(null);
     } else {
       this.logger.info({ limit: this.limit }, 'Storage memory has reached limit of @{limit} packages');
-      return new Error('Storage memory has reached limit of limit packages');
+      cb(new Error('Storage memory has reached limit of limit packages'));
     }
   }
 
-  remove(name: string) {
+  remove(name: string, cb: Callback) {
     const { list } = this.data;
-    const i = list.indexOf(name);
-    if (i !== -1) {
-      list.splice(i, 1);
+    const item = list.indexOf(name);
+
+    if (item !== -1) {
+      list.splice(item, 1);
     }
+
+    cb(null);
   }
 
-  get() {
-    return this.data.list;
+  get(cb: Callback) {
+    cb(null, this.data.list);
   }
 
   sync() {

plugins/memory/test/memory.spec.js

@@ -26,28 +26,49 @@ describe('memory unit test .', () => {
       expect(localMemory).toBeDefined();
     });
 
-    test('should create add a package', () => {
+    test('should create add a package', done => {
       const localMemory: ILocalData = new LocalMemory(config, { logger });
-      localMemory.add('test');
-
-      expect(localMemory.get()).toHaveLength(1);
+      localMemory.add('test', err => {
+        expect(err).toBeNull();
+        localMemory.get((err, data) => {
+          expect(err).toBeNull();
+          expect(data).toHaveLength(1);
+          done();
+        });
+      });
     });
 
-    test('should reach max limit', () => {
+    test('should reach max limit', done => {
       config.limit = 2;
       const localMemory: ILocalData = new LocalMemory(config, { logger });
-      expect(localMemory.add('test1')).toBeUndefined();
-      expect(localMemory.add('test2')).toBeUndefined();
-      expect(localMemory.add('test3')).not.toBeNull();
+
+      localMemory.add('test1', err => {
+        expect(err).toBeNull();
+        localMemory.add('test2', err => {
+          expect(err).toBeNull();
+          localMemory.add('test3', err => {
+            expect(err).not.toBeNull();
+            expect(err.message).toMatch(/Storage memory has reached limit of limit packages/);
+            done();
+          });
+        });
+      });
     });
 
-    test('should remove a package', () => {
+    test('should remove a package', done => {
       const pkgName: string = 'test';
       const localMemory: ILocalData = new LocalMemory(config, { logger });
-      localMemory.add(pkgName);
-      localMemory.remove(pkgName);
-
-      expect(localMemory.get()).toHaveLength(0);
+      localMemory.add(pkgName, err => {
+        expect(err).toBeNull();
+        localMemory.remove(pkgName, err => {
+          expect(err).toBeNull();
+          localMemory.get((err, data) => {
+            expect(err).toBeNull();
+            expect(data).toHaveLength(0);
+            done();
+          });
+        });
+      });
     });
   });
 

plugins/memory/yarn.lock

@@ -218,9 +218,9 @@
   version "1.0.0"
   resolved "https://registry.npmjs.org/@verdaccio/streams/-/streams-1.0.0.tgz#d5d24c6747208728b9fd16b908e3932c3fb1f864"
 
-"@verdaccio/types@0.2.4":
-  version "2.0.5"
-  resolved "https://registry.npmjs.org/@verdaccio/types/-/types-2.0.5.tgz#a35682b0268a242c5fefded54f79a6b4d34dfa88"
+"@verdaccio/types@2.1.0":
+  version "2.1.0"
+  resolved "https://registry.npmjs.org/@verdaccio/types/-/types-2.1.0.tgz#1a0b330f96bc63fbc87391c2b5c625fd3be5da84"
 
 JSONStream@^1.0.4:
   version "1.3.2"