Replace fs.exists with other fileSystem alternatives#159
Merged
juanpicado merged 5 commits intoverdaccio:masterfrom Oct 5, 2019
Merged
Replace fs.exists with other fileSystem alternatives#159juanpicado merged 5 commits intoverdaccio:masterfrom
juanpicado merged 5 commits intoverdaccio:masterfrom
Conversation
fs.exists is deprecated starting from node12.
fs.exists is deprecated starting from node 12
shrirambalaji
changed the title
Member
|
@sergiohgz I think the token just expired, it failed on publish |
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 65.29% 65.29% +<.01%
==========================================
Files 25 25
Lines 1386 1389 +3
Branches 198 199 +1
==========================================
+ Hits 905 907 +2
- Misses 479 480 +1
Partials 2 2
Continue to review full report at Codecov.
|
DanielRuf
suggested changes
Oct 5, 2019
…aji/verdaccio-monorepo into replace-fs-exists-in-node-12
DanielRuf
approved these changes
Oct 5, 2019
Member
|
Thanks guys !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: chore
Scope: plugins/local-storage
The following has been addressed in the PR:
Description:
This PR removes our usage of
fs.existsand replaces it with other file system API alternatives likefs.accessandfs.stat.Resolves https://github.com/verdaccio/monorepo/issues/60