fix(verdaccio-google-cloud): catch missing Secret on first run#247
Merged
juanpicado merged 1 commit intoverdaccio:masterfrom Dec 28, 2019
Merged
fix(verdaccio-google-cloud): catch missing Secret on first run#247juanpicado merged 1 commit intoverdaccio:masterfrom
juanpicado merged 1 commit intoverdaccio:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 65.45% 65.31% -0.14%
==========================================
Files 26 26
Lines 1401 1404 +3
Branches 201 201
==========================================
Hits 917 917
- Misses 482 485 +3
Partials 2 2
Continue to review full report at Codecov.
|
in getSecret, if /Secret does not exist, we had an async error uncaught. Catch it explicitly so that the Secret will get created.
donbowman
force-pushed
the
catch-no-secret
branch
from
473303d to
fabd384
Compare
donbowman
changed the title
Contributor
Author
|
I'm not sure what i'm supposed to do, the failure is: but i'm unclear on why a job run on my behalf would have permissions to publish or where they would come from. |
DanielRuf
approved these changes
Dec 26, 2019
Contributor
DanielRuf
left a comment
DanielRuf
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your contribution to verdaccio.
juanpicado
approved these changes
Dec 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in getSecret, if /Secret does not exist, we had an async
error uncaught. Catch it explicitly so that the Secret
will get created.
Type:
Scope:
The following has been addressed in the PR:
Description: