Merged
Conversation
this is disabled by prettier default config and we want it enabled it
9d3a72c to
0d25a2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 65.33% 65.31% -0.03%
==========================================
Files 26 26
Lines 1402 1404 +2
Branches 202 205 +3
==========================================
+ Hits 916 917 +1
Misses 484 484
- Partials 2 3 +1
Continue to review full report at Codecov.
|
Member
Author
|
Intersting ... |
DanielRuf
approved these changes
Dec 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feat
Scope: eslint
The following has been addressed in the PR:
Description:
this is disabled by prettier default config and we want it enabled it
I notice that #289 allows curly and our config should forbid such practice.