separate s3 subfolders (key prefix for different packages)#313
Merged
juanpicado merged 13 commits intoverdaccio:masterfrom Jan 23, 2020
Merged
separate s3 subfolders (key prefix for different packages)#313juanpicado merged 13 commits intoverdaccio:masterfrom
juanpicado merged 13 commits intoverdaccio:masterfrom
Conversation
added 7 commits
January 16, 2020 12:07
Remove packagename as key for s3 objects Add package path from custom storage of packages
remove the duplications in trailing slash on paths
this folder is used per convention for minio or localstack for database
this is to access the packages and their store key
Member
|
🚀🙏 |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 65.17% 70.62% +5.45%
==========================================
Files 26 27 +1
Lines 1407 1413 +6
Branches 205 206 +1
==========================================
+ Hits 917 998 +81
+ Misses 487 412 -75
Partials 3 3
Continue to review full report at Codecov.
|
juanpicado
reviewed
Jan 21, 2020
juanpicado
reviewed
Jan 21, 2020
juanpicado
reviewed
Jan 21, 2020
juanpicado
reviewed
Jan 21, 2020
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
I like it, test included 🥇 , still checking this but looks pretty promising, we should ignore some Docker files + config with the .npmignore so are not bundle in the tarball.
juanpicado
reviewed
Jan 21, 2020
added 5 commits
January 21, 2020 09:38
aws-s3-storage plugin
Update the README
juanpicado
approved these changes
Jan 23, 2020
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
Impeccable 👌 thanks so much for taking care of this
juanpicado
pushed a commit
that referenced
this pull request
Jan 23, 2020
* test: createPackage with s3 mock * feat: Add Custom Storage Remove packagename as key for s3 objects Add package path from custom storage of packages * test: Add number of assertions to tests * refactor: trailing slash function remove the duplications in trailing slash on paths * chore: add data to gitignore this folder is used per convention for minio or localstack for database * fix: replace s3config with whole config this is to access the packages and their store key * Add readme section * fix: jest registry in yarn.lock * Upgrade: aws-sdk aws-s3-storage plugin * fix: set minio endpoint in config.yaml * fix: Remove registry.env file from repo Update the README * Fix: aws secret access key example in README * Add npmignore
juanpicado
pushed a commit
that referenced
this pull request
Jan 23, 2020
…r different packages) (#313) * test: createPackage with s3 mock * feat: Add Custom Storage Remove packagename as key for s3 objects Add package path from custom storage of packages * test: Add number of assertions to tests * refactor: trailing slash function remove the duplications in trailing slash on paths * chore: add data to gitignore this folder is used per convention for minio or localstack for database * fix: replace s3config with whole config this is to access the packages and their store key * Add readme section * fix: jest registry in yarn.lock * Upgrade: aws-sdk aws-s3-storage plugin * fix: set minio endpoint in config.yaml * fix: Remove registry.env file from repo Update the README * Fix: aws secret access key example in README * Add npmignore
Author
my pleasure. This was a really good foundation for future work together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/verdaccio/verdaccio/blob/master/CONTRIBUTING.md#git-commit-guidelines
Type: Feature
Scope: aws-s3-storage plugin
The following has been addressed in the PR:
Description:
the s3 plugin adds all packages (proxy or none proxy) flat out in the root of the s3 bucket. This PR resolves that issue by using the storage key in the packages section of the config file as a folder in s3 bucket