chore: apply suggestions

Author: juanpicado

src/App/Header/LoginDialog/LoginDialog.tsx

@@ -25,7 +25,6 @@ const LoginDialog: React.FC<Props> = ({ onClose, open = false }) => {
   const appContext = useContext(AppContext);
   const { doLogin } = useAPI();
 
-  // eslint-disable-next-line react-hooks/exhaustive-deps
   const makeLogin = useCallback(
     async (username?: string, password?: string): Promise<LoginBody> => {
       // checks isEmpty

src/design-tokens/ThemeProvider.tsx

@@ -1,7 +1,7 @@
 import { ThemeProvider as MuiThemeProvider } from '@material-ui/core/styles';
 import { ThemeProvider as EmotionThemeProvider } from 'emotion-theming';
 import i18next from 'i18next';
-import React, { useEffect } from 'react';
+import React, { useEffect, useCallback } from 'react';
 
 import { useConfig } from 'verdaccio-ui/providers/config';
 
@@ -21,18 +21,21 @@ const ThemeProvider: React.FC = ({ children }) => {
 
   const themeMode: ThemeMode = isDarkMode ? 'dark' : 'light';
 
-  const changeLanguage = async () => {
+  const changeLanguage = useCallback(async () => {
     await i18next.changeLanguage(language);
-  };
+  }, [language]);
+
+  const currentTheme = getTheme(themeMode, configOptions?.primaryColor);
 
   useEffect(() => {
     changeLanguage();
     loadDayJSLocale();
   }, [language, changeLanguage]);
+
   return (
     <ThemeContext.Provider value={{ isDarkMode, setIsDarkMode, language, setLanguage }}>
-      <EmotionThemeProvider theme={getTheme(themeMode, configOptions?.primaryColor)}>
-        <MuiThemeProvider theme={getTheme(themeMode, configOptions?.primaryColor)}>{children}</MuiThemeProvider>
+      <EmotionThemeProvider theme={currentTheme}>
+        <MuiThemeProvider theme={currentTheme}>{children}</MuiThemeProvider>
       </EmotionThemeProvider>
     </ThemeContext.Provider>
   );

src/providers/API/APIProvider.tsx

@@ -65,30 +65,23 @@ const APIProvider: FunctionComponent = ({ children }) => {
   };
 
   const doLogin = async (username: string, password: string): Promise<LoginBody> => {
-    const response: LoginBody = await API.request(buildURL('login'), 'POST', {
+    return await API.request(buildURL('login'), 'POST', {
       body: JSON.stringify({ username, password }),
       headers: {
         Accept: HEADERS.JSON,
         'Content-Type': HEADERS.JSON,
       },
     });
-    const result: LoginBody = {
-      username: response.username,
-      token: response.token,
-    };
-    return result;
   };
 
   const getResource = async (link: string): Promise<Blob> => {
-    const fileStream: Blob = await API.request(link, 'GET', {
+    return await API.request(link, 'GET', {
       headers: {
         ['accept']:
           'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3',
       },
       credentials: 'include',
     });
-
-    return fileStream;
   };
 
   const value = useMemo(
@@ -108,6 +101,4 @@ const APIProvider: FunctionComponent = ({ children }) => {
 
 export default APIProvider;
 
-const useAPI = () => useContext(AppAPIContext);
-
-export { useAPI };
+export const useAPI = () => useContext(AppAPIContext);