Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

Commit 6be8891

Browse files
Merge branch 'refactor/162_introduced_forwardRef_listItem' of github.com:verdaccio/ui into refactor/162_introduced_forwardRef_listItem
2 parents 35cb0b4 + a1746a0 commit 6be8891

File tree

3 files changed

+24
-15
lines changed

3 files changed

+24
-15
lines changed

src/App/App.tsx

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,30 @@ import '../utils/styles/global';
1414
import 'normalize.css';
1515
import Footer from '../components/Footer';
1616
import { FormError } from '../components/Login/Login';
17+
import { PackageInterface } from '../components/Package/Package';
1718

18-
export const AppContext = React.createContext<{}>({});
19-
export const AppContextProvider = AppContext.Provider;
20-
export const AppContextConsumer = AppContext.Consumer;
21-
22-
export interface AppStateInterface {
23-
error?: FormError;
19+
interface AppContextData {
2420
logoUrl: string;
21+
scope: string;
22+
isUserLoggedIn: boolean;
23+
packages: PackageInterface[];
2524
user: {
2625
username?: string;
2726
};
28-
scope: string;
27+
}
28+
export const AppContext = React.createContext<AppContextData>({
29+
logoUrl: window.VERDACCIO_LOGO,
30+
user: {},
31+
scope: window.VERDACCIO_SCOPE || '',
32+
isUserLoggedIn: false,
33+
packages: [],
34+
});
35+
const AppContextProvider = AppContext.Provider;
36+
export const AppContextConsumer = AppContext.Consumer;
37+
38+
export interface AppStateInterface extends AppContextData {
39+
error?: FormError;
2940
showLoginModal: boolean;
30-
isUserLoggedIn: boolean;
31-
packages: any[];
3241
isLoading: boolean;
3342
}
3443
export default class App extends Component<{}, AppStateInterface> {

src/pages/home/Home.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import React from 'react';
22

33
import PackageList from '../../components/PackageList';
4+
import { PackageInterface } from '../../components/Package/Package';
45

56
interface Props {
67
isUserLoggedIn: boolean;
7-
packages: [];
8+
packages: PackageInterface[];
89
}
910

1011
const Home: React.FC<Props> = ({ packages }) => (

src/router.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import React, { Component, ReactElement } from 'react';
44
import { Router, Route, Switch } from 'react-router-dom';
55
import { createBrowserHistory } from 'history';
66

7-
import { AppContextConsumer, AppStateInterface } from './App/App';
7+
import { AppContextConsumer } from './App/App';
88
import Header from './components/Header';
99

1010
const history = createBrowserHistory({
@@ -44,7 +44,7 @@ class RouterApp extends Component<RouterAppProps> {
4444

4545
return (
4646
<AppContextConsumer>
47-
{function renderConsumerVersionPage({ logoUrl, scope = '', user }: Partial<AppStateInterface>) {
47+
{function renderConsumerVersionPage({ logoUrl, scope = '', user }) {
4848
return <Header logo={logoUrl} onLogout={onLogout} onToggleLoginModal={onToggleLoginModal} scope={scope} username={user && user.username} />;
4949
}}
5050
</AppContextConsumer>
@@ -54,8 +54,7 @@ class RouterApp extends Component<RouterAppProps> {
5454
public renderHomePage = (): ReactElement<HTMLDivElement> => {
5555
return (
5656
<AppContextConsumer>
57-
{function renderConsumerVersionPage({ isUserLoggedIn, packages }: Partial<AppStateInterface>) {
58-
// @ts-ignore
57+
{function renderConsumerVersionPage({ isUserLoggedIn, packages }) {
5958
return <HomePage isUserLoggedIn={isUserLoggedIn} packages={packages} />;
6059
}}
6160
</AppContextConsumer>
@@ -65,7 +64,7 @@ class RouterApp extends Component<RouterAppProps> {
6564
public renderVersionPage = (routerProps): ReactElement<HTMLDivElement> => {
6665
return (
6766
<AppContextConsumer>
68-
{function renderConsumerVersionPage({ isUserLoggedIn }: Partial<AppStateInterface>) {
67+
{function renderConsumerVersionPage({ isUserLoggedIn }) {
6968
return <VersionPackage {...routerProps} isUserLoggedIn={isUserLoggedIn} />;
7069
}}
7170
</AppContextConsumer>

0 commit comments

Comments
 (0)