Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

chore: refactoring version page / fix issue not found page #100#117

Merged
juanpicado merged 11 commits intomasterfrom
refactor-version-page
Aug 25, 2019
Merged

chore: refactoring version page / fix issue not found page #100#117
juanpicado merged 11 commits intomasterfrom
refactor-version-page

Conversation

@juanpicado
Copy link
Copy Markdown
Member

@juanpicado juanpicado commented Aug 21, 2019

Type: refactor/bug

Description:

  • Use hooks (simplify the component)
  • Improve imports, better access to module imports
  • Add tests (here we use testing library with basic render)
  • Increase coverage and add more testing scenarios

The following has been addressed in the PR:

  • There is a related issue? yes

Resolves #100

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 24, 2019

Codecov Report

Merging #117 into master will increase coverage by 10.66%.
The diff coverage is 93.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #117       +/-   ##
=========================================
+ Coverage   74.34%    85%   +10.66%     
=========================================
  Files          89     92        +3     
  Lines         877    887       +10     
  Branches      157    157               
=========================================
+ Hits          652    754      +102     
+ Misses        212    115       -97     
- Partials       13     18        +5
Impacted Files Coverage Δ
src/components/Engines/Engines.tsx 100% <ø> (ø) ⬆️
src/components/Repository/Repository.tsx 100% <ø> (ø) ⬆️
src/components/UpLinks/UpLinks.tsx 30% <ø> (ø) ⬆️
src/components/Versions/Versions.tsx 75% <ø> (ø) ⬆️
src/components/Developers/Developers.tsx 100% <ø> (ø) ⬆️
src/components/ActionBar/ActionBar.tsx 83.33% <ø> (ø) ⬆️
src/components/Author/Author.tsx 100% <ø> (ø) ⬆️
src/components/Dist/Dist.tsx 100% <ø> (ø) ⬆️
src/components/Install/Install.tsx 83.33% <ø> (+33.33%) ⬆️
src/components/Dependencies/Dependencies.tsx 2.77% <ø> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d3c46...6b53077. Read the comment docs.

@juanpicado juanpicado marked this pull request as ready for review August 25, 2019 11:48
@juanpicado juanpicado changed the title [WIP] chore: refactoring version page chore: refactoring version page / fix issue not found page #100 Aug 25, 2019
@juanpicado juanpicado merged commit 97e8448 into master Aug 25, 2019
@juanpicado juanpicado deleted the refactor-version-page branch August 25, 2019 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If package is not found, the website does not render 404 page

2 participants