This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: warning about modules with names differing in casing#148
Merged
priscilawebdev merged 1 commit intoverdaccio:masterfrom Oct 2, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 84.12% 84.12%
=======================================
Files 92 92
Lines 926 926
Branches 166 151 -15
=======================================
Hits 779 779
- Misses 128 132 +4
+ Partials 19 15 -4
Continue to review full report at Codecov.
|
priscilawebdev
approved these changes
Oct 2, 2019
Contributor
|
Thank you @antoinechalifour 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type:
The following has been addressed in the PR:
This PR removes a warning in the dev environment.
Description:
The
module.acceptmethod was called with a different casing with resulted in a warning in the console :)