Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

Fix some warnings in console#155

Merged
juanpicado merged 4 commits intoverdaccio:masterfrom
antoinechalifour:fix-warnings
Oct 4, 2019
Merged

Fix some warnings in console#155
juanpicado merged 4 commits intoverdaccio:masterfrom
antoinechalifour:fix-warnings

Conversation

@antoinechalifour
Copy link
Copy Markdown
Contributor

Type: Fix

The following has been addressed in the PR:

  • There is a related issue? No
  • Unit or Functional tests are included in the PR

Description:

Fixes 2 warnings in the console:

  • unknown react emotion selector
  • DOM nesting validation (div cannot be a child of p)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 4, 2019

Codecov Report

Merging #155 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage    83.4%   83.33%   -0.08%     
==========================================
  Files          98       98              
  Lines         946      948       +2     
  Branches      165      151      -14     
==========================================
+ Hits          789      790       +1     
- Misses        141      145       +4     
+ Partials       16       13       -3
Impacted Files Coverage Δ
src/components/Footer/styles.ts 100% <ø> (ø) ⬆️
src/components/DetailSidebar/DetailSidebar.tsx 85% <0%> (-4.48%) ⬇️
src/components/DetailSidebar/styles.ts 100% <100%> (ø) ⬆️
src/components/Header/Header.tsx 89.47% <0%> (ø) ⬆️
src/components/Install/Install.tsx 83.33% <0%> (ø) ⬆️
...mponents/RegistryInfoDialog/RegistryInfoDialog.tsx 66.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd9eb7...068ca87. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants