This repository was archived by the owner on Jan 16, 2022. It is now read-only.
refactor: convert Dist component to hooks#156
Merged
juanpicado merged 3 commits intoverdaccio:masterfrom Oct 5, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 83.33% 83.15% -0.18%
==========================================
Files 98 98
Lines 948 944 -4
Branches 166 165 -1
==========================================
- Hits 790 785 -5
- Misses 141 142 +1
Partials 17 17
Continue to review full report at Codecov.
|
bighuggies
commented
Oct 3, 2019
| }; | ||
|
|
||
| const chipsList = Object.keys(distDict).map((dist, key) => { | ||
| if (!distDict[dist]) return; |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is a bug or intentional, but this will hide the chips for file count or size if they happen to be 0. I've done a strict refactor and included the same behavior.
juanpicado
approved these changes
Oct 5, 2019
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
🚀 perfect ! thanks @bighuggies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: refactor
The following has been addressed in the PR: #116
Description:
Very similar to #150
Distcomponent to a function componentDetailContextconsumer touseContexthook