This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Routes - Replaced class by func. comp#159
Merged
juanpicado merged 6 commits intomasterfrom Oct 19, 2019
Merged
Conversation
juanpicado
reviewed
Oct 5, 2019
priscilawebdev
force-pushed
the
refactor/116_convert_class_to_func_router
branch
from
27c05da to
6783b05
Compare
priscilawebdev
changed the title
juanpicado
reviewed
Oct 13, 2019
juanpicado
reviewed
Oct 13, 2019
juanpicado
reviewed
Oct 13, 2019
priscilawebdev
changed the title
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=========================================
+ Coverage 86.84% 86.95% +0.1%
=========================================
Files 116 117 +1
Lines 882 874 -8
Branches 141 160 +19
=========================================
- Hits 766 760 -6
+ Misses 103 97 -6
- Partials 13 17 +4
|
tmkn
reviewed
Oct 17, 2019
juanpicado
approved these changes
Oct 19, 2019
delete-merged-branch
bot
deleted the
refactor/116_convert_class_to_func_router
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #116
Unit or Functional tests are included in the PR?
in progress
Description:
in order to use react hooks, in this PR I updated the routes by changing it from a class to a functional component. I have also splitted it's content so that it is clearer.