This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: incorrect Tooltip import in avatar component#160
Merged
priscilawebdev merged 4 commits intoverdaccio:masterfrom Oct 6, 2019
Merged
fix: incorrect Tooltip import in avatar component#160priscilawebdev merged 4 commits intoverdaccio:masterfrom
priscilawebdev merged 4 commits intoverdaccio:masterfrom
Conversation
Member
|
I will check it |
priscilawebdev
approved these changes
Oct 6, 2019
priscilawebdev
previously approved these changes
Oct 6, 2019
Contributor
|
@bighuggies I believe you forgot to update snapshots |
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 97 97
Lines 928 928
Branches 163 163
=======================================
Hits 770 770
Misses 141 141
Partials 17 17
Continue to review full report at Codecov.
|
priscilawebdev
approved these changes
Oct 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: fix
The following has been addressed in the PR:
Fixes a rendering issue with the developer avatars in the sidebar as pointed out by @juanpicado:
Now:
I haven't been able to get snapshots to generate correctly on my machine so the tests are failing atm.