This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Better type inference for MediaQuery#180
Merged
juanpicado merged 3 commits intoverdaccio:masterfrom Oct 13, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 88.9% 88.73% -0.17%
==========================================
Files 117 117
Lines 928 932 +4
Branches 147 147
==========================================
+ Hits 825 827 +2
- Misses 90 92 +2
Partials 13 13
|
juanpicado
reviewed
Oct 13, 2019
juanpicado
approved these changes
Oct 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
media.tscompatible withnoImplicitAny.While the code is now a little more verbose, TypeScript is now able to infer the types naturally, without any casts.
Consumption of the
MediaQueryobject stayed the same.