This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Fixed type inference for AppContext#188
Merged
juanpicado merged 2 commits intoverdaccio:masterfrom Oct 12, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 88.75% 88.76% +0.01%
==========================================
Files 113 113
Lines 916 917 +1
Branches 162 163 +1
==========================================
+ Hits 813 814 +1
Misses 89 89
Partials 14 14
|
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a
tsignoreand fixes the underlying complaint by providing better type inference forAppContext.AppContext.Consumercan infer the context naturally, however due to the wayAppContextwas typed this was not the case and it complained in some places withouttsignore. This PR fixes those complaints.