This repository was archived by the owner on Jan 16, 2022. It is now read-only.
refactor:116[PackageList] component is converted to functional#219
Merged
juanpicado merged 2 commits intoverdaccio:masterfrom Oct 26, 2019
alfonsoar:refactor/116_packageList_is_converted_to_functional_component
Merged
refactor:116[PackageList] component is converted to functional#219juanpicado merged 2 commits intoverdaccio:masterfrom alfonsoar:refactor/116_packageList_is_converted_to_functional_component
juanpicado merged 2 commits intoverdaccio:masterfrom
alfonsoar:refactor/116_packageList_is_converted_to_functional_component
Conversation
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 87.55% 87.51% -0.05%
==========================================
Files 118 118
Lines 876 873 -3
Branches 160 160
==========================================
- Hits 767 764 -3
Misses 94 94
Partials 15 15
|
juanpicado
reviewed
Oct 26, 2019
| @@ -1,4 +1,4 @@ | |||
| import React, { Fragment, ReactElement } from 'react'; | |||
| import * as React from 'react'; | |||
Member
There was a problem hiding this comment.
We usually uses import React, { Fragment, ReactElement } from 'react'; format, this is for consistence and using * is not a good practice in general.
Member
Author
There was a problem hiding this comment.
@juanpicado understood I will follow the former pattern for future PRs. Out of curiosity what makes * not good practice? is it just cause we are importing everything?
…unctional_component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR:
Description:
Refactor PackageList component to functional