This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Login Dialog Component - Replaced class by func. comp + added react-hook-form#341
Merged
juanpicado merged 17 commits intomasterfrom Dec 6, 2019
Merged
Conversation
juanpicado
reviewed
Dec 5, 2019
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
What a beauty :-) looking forward ...
…ub.com:verdaccio/ui into refactor/116_convert_class_too_func_loginmodal
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 87.86% 87.62% -0.25%
==========================================
Files 142 141 -1
Lines 972 937 -35
Branches 189 182 -7
==========================================
- Hits 854 821 -33
+ Misses 101 99 -2
Partials 17 17
|
priscilawebdev
force-pushed
the
refactor/116_convert_class_too_func_loginmodal
branch
from
e6e6f2f to
d64bd9c
Compare
|
is this closed? Can I work on this? |
juanpicado
reviewed
Dec 6, 2019
| "react/jsx-indent-props": ["error", 2], | ||
| "react/jsx-key": ["error"], | ||
| "react/jsx-max-depth": ["error", { "max": 2}], | ||
| "react/jsx-max-depth":["error", { "max": 5}], |
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
Member
|
Great job here ! 👏 |
delete-merged-branch
bot
deleted the
refactor/116_convert_class_too_func_loginmodal
branch
Contributor
Author
|
@juanpicado thanks 🙃🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Refactor
The following has been addressed in the PR: #116
Description:
in order to use react hooks, in this PR I updated the Login Dialog component by changing it from a class to a functional component.
I've also made it more pretty 💅
Others things done in this PR:
I have turned off this lint rule: react/jsx-max-depth, because it is not really helpful. Please do you agree with me?
I introduced this amazing library: React-hook-form, in order to have a better form's state management + less verbose + better performance. The library is also very lightweight with only 5.7kB (minified + GZIPPED) 👏
I installed
mutationobserver-shimlibrary to fix some tests issue. please see: