Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix: engine warning on console for ui#403

Merged
juanpicado merged 5 commits intomasterfrom
fix-402
Dec 30, 2019
Merged

fix: engine warning on console for ui#403
juanpicado merged 5 commits intomasterfrom
fix-402

Conversation

@juanpicado
Copy link
Copy Markdown
Member

Type: bug

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

"engines": {
    "node": ">= 10.13.0",
    "node": ">= 8",
    "npm": ">=5"
  },

We still support v8 and this is a dependency of verdaccio.

Resolves https://github.com/verdaccio/ui/issues/402

@juanpicado juanpicado requested a review from DanielRuf December 30, 2019 08:14
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@787dda4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #403   +/-   ##
=========================================
  Coverage          ?   87.81%           
=========================================
  Files             ?      137           
  Lines             ?      952           
  Branches          ?      211           
=========================================
  Hits              ?      836           
  Misses            ?      102           
  Partials          ?       14

DanielRuf
DanielRuf previously approved these changes Dec 30, 2019
@juanpicado
Copy link
Copy Markdown
Member Author

Yes, it does, but I think nobody is developing on Node 8` anyway. The change webpack-contrib/url-loader#198 does not affect the library behavior.

This is just a dependency and we ship a webpack bundle. I updated the README.

@DanielRuf
Copy link
Copy Markdown
Contributor

This is just a dependency and we ship a webpack bundle. I updated the README.

You are right. I saw the other comment about the devDependency so this is not relevant for the prod bundles as you wrote =)

DanielRuf
DanielRuf previously approved these changes Dec 30, 2019
Co-Authored-By: Daniel Ruf <[email protected]>
@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/[email protected] --registry https://registry.verdaccio.org

@juanpicado juanpicado merged commit d554049 into master Dec 30, 2019
@juanpicado juanpicado deleted the fix-402 branch December 30, 2019 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node >= 10.13.0 wanted

3 participants