This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: remove prevent default and use react context#411
Merged
juanpicado merged 3 commits intomasterfrom Jan 8, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 137 137
Lines 956 956
Branches 198 211 +13
=======================================
Hits 845 845
+ Misses 99 98 -1
- Partials 12 13 +1
|
DanielRuf
reviewed
Jan 4, 2020
DanielRuf
reviewed
Jan 5, 2020
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
Member
Author
|
@DanielRuf reminder :) |
Contributor
|
Testing now. |
DanielRuf
approved these changes
Jan 8, 2020
Contributor
DanielRuf
left a comment
DanielRuf
left a comment
There was a problem hiding this comment.
LGTM
I have added the funding field to partials/storage/jquery/package.json and clicked on the button:
"3.3.1": {
"funding": {
"url": "https://example.com"
},
"name": "jquery",
"title": "jQuery",
And it worked, I was redirected to example.com.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
contextas the other components in the same parent ( for consistence )Resolves #410