Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

ref(styles): Updated dark colors#455

Merged
juanpicado merged 2 commits intomasterfrom
ref/dark-mode-links-too-dark
Apr 5, 2020
Merged

ref(styles): Updated dark colors#455
juanpicado merged 2 commits intomasterfrom
ref/dark-mode-links-too-dark

Conversation

@priscilawebdev
Copy link
Copy Markdown
Contributor

@priscilawebdev priscilawebdev commented Apr 5, 2020

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@priscilawebdev priscilawebdev changed the title ref(styles): updated dark colors ref(styles): Updated dark colors Apr 5, 2020
@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/[email protected] --registry https://registry.verdaccio.org

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2020

Codecov Report

Merging #455 into master will decrease coverage by 0.75%.
The diff coverage is 51.85%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   85.22%   84.47%   -0.76%     
==========================================
  Files         141      141              
  Lines        1022     1011      -11     
  Branches      210      198      -12     
==========================================
- Hits          871      854      -17     
  Misses        125      125              
- Partials       26       32       +6     
Impacted Files Coverage Δ
src/components/Header/HeaderMenu.tsx 100.00% <ø> (ø)
src/components/Icon/styles.ts 88.88% <ø> (ø)
src/design-tokens/theme.ts 100.00% <ø> (ø)
src/components/Package/styles.ts 74.07% <12.50%> (-3.71%) ⬇️
src/components/ActionBar/ActionBarAction.tsx 77.77% <33.33%> (-22.23%) ⬇️
src/components/Header/styles.ts 71.42% <50.00%> (-11.91%) ⬇️
src/components/Footer/styles.ts 83.33% <66.66%> (-5.56%) ⬇️
src/components/LoginDialog/LoginDialogHeader.tsx 71.42% <66.66%> (-11.91%) ⬇️
src/components/NotFound/NotFound.tsx 88.88% <66.66%> (-11.12%) ⬇️
...mponents/DetailSidebar/DetailSidebarFundButton.tsx 100.00% <100.00%> (ø)
... and 1 more

Copy link
Copy Markdown
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@juanpicado juanpicado merged commit d29aa05 into master Apr 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the ref/dark-mode-links-too-dark branch April 5, 2020 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode and links are too dark

4 participants