This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: when scope is provided use proper separator#457
Merged
priscilawebdev merged 4 commits intoverdaccio:masterfrom May 5, 2020
Merged
fix: when scope is provided use proper separator#457priscilawebdev merged 4 commits intoverdaccio:masterfrom
priscilawebdev merged 4 commits intoverdaccio:masterfrom
Conversation
it's not documented particularly well but ":" needs to be set between the scope and "registry" in order to set the proper .npmrc config https://docs.npmjs.com/files/npmrc#comments this demonstrates it well although the link is for a different topic this was incorrectly fixed in verdaccio#34
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 142 142
Lines 1083 1083
Branches 209 222 +13
=======================================
Hits 897 897
+ Misses 154 153 -1
- Partials 32 33 +1
|
juanpicado
reviewed
Apr 8, 2020
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
Thanks for this PR, would be great to have unit test for this 🙏
Contributor
Author
Added some unit tests, let me know if they're ok. |
juanpicado
previously approved these changes
May 4, 2020
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
LGTM, sorry the delay I totally missed your PR
Contributor
|
@JGjorgji thanks for this great PR. If you don't mind I've updated one minor thing :) |
priscilawebdev
previously approved these changes
May 5, 2020
Contributor
priscilawebdev
left a comment
priscilawebdev
left a comment
There was a problem hiding this comment.
LGTM ...thanks!! 👏
priscilawebdev
force-pushed
the
fix-npm-set-scope
branch
from
b52044e to
3b87165
Compare
|
SonarCloud Quality Gate failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Fix
Description:
it's not documented particularly well but ":" needs to be set between
the scope and "registry" in order to set the proper .npmrc config
https://docs.npmjs.com/files/npmrc#comments
this demonstrates it well although the link is for a different topic
this was incorrectly fixed in #34