Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat: add japanese translations#460

Merged
juanpicado merged 5 commits intoverdaccio:masterfrom
hdmr14:master
Apr 24, 2020
Merged

feat: add japanese translations#460
juanpicado merged 5 commits intoverdaccio:masterfrom
hdmr14:master

Conversation

@hdmr14
Copy link
Copy Markdown
Contributor

@hdmr14 hdmr14 commented Apr 22, 2020

Type: translation

The following has been addressed in the PR:

  • There is a related issue?
    NO
  • Unit or Functional tests are included in the PR
    NO

Description: Add Japanese translations(ja-JP)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2020

Codecov Report

Merging #460 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   84.22%   83.97%   -0.25%     
==========================================
  Files         141      141              
  Lines        1014     1017       +3     
  Branches      210      198      -12     
==========================================
  Hits          854      854              
- Misses        127      131       +4     
+ Partials       33       32       -1     
Impacted Files Coverage Δ
i18n/config.ts 100.00% <ø> (ø)
src/App/load-dayjs-locale.ts 23.33% <0.00%> (-2.60%) ⬇️
src/components/Icon/styles.ts 88.88% <0.00%> (ø)

juanpicado
juanpicado previously approved these changes Apr 23, 2020
Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely ❤️ 🇯🇵 !! Thanks !

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2020

Codecov Report

Merging #460 into master will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   83.41%   83.17%   -0.24%     
==========================================
  Files         142      142              
  Lines        1067     1070       +3     
  Branches      211      223      +12     
==========================================
  Hits          890      890              
- Misses        145      147       +2     
- Partials       32       33       +1     
Impacted Files Coverage Δ
i18n/config.ts 100.00% <ø> (ø)
src/App/load-dayjs-locale.ts 23.33% <0.00%> (-2.60%) ⬇️
src/components/Icon/styles.ts 88.88% <0.00%> (ø)

@hdmr14
Copy link
Copy Markdown
Contributor Author

hdmr14 commented Apr 23, 2020

Ah, I missed redundant words(コンテキスト = Context) in translation.
It fixed now.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanpicado juanpicado merged commit 25def6c into verdaccio:master Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants