Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix(i18n): fixed current locale#462

Merged
juanpicado merged 2 commits intomasterfrom
fix/current-locale
Apr 27, 2020
Merged

fix(i18n): fixed current locale#462
juanpicado merged 2 commits intomasterfrom
fix/current-locale

Conversation

@priscilawebdev
Copy link
Copy Markdown
Contributor

@priscilawebdev priscilawebdev commented Apr 26, 2020

Type: Fix

The following has been addressed in the PR: https://github.com/verdaccio/ui/issues/461

  • There is a related issue? Yes

Description:

Closes https://github.com/verdaccio/ui/issues/461 & added missing Japanese translations

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 26, 2020

Codecov Report

Merging #462 into master will decrease coverage by 0.44%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   83.17%   82.72%   -0.45%     
==========================================
  Files         142      142              
  Lines        1070     1077       +7     
  Branches      223      222       -1     
==========================================
+ Hits          890      891       +1     
- Misses        147      153       +6     
  Partials       33       33              
Impacted Files Coverage Δ
src/components/Icon/Icon.tsx 100.00% <ø> (ø)
src/components/LanguageSwitch/LanguageSwitch.tsx 56.60% <41.66%> (-6.44%) ⬇️
src/design-tokens/ThemeProvider.tsx 100.00% <100.00%> (ø)

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@priscilawebdev
Copy link
Copy Markdown
Contributor Author

@hdmr14 ありがとうございました 🙏

@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/[email protected] --registry https://registry.verdaccio.org

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@juanpicado juanpicado merged commit f44abd7 into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/current-locale branch April 27, 2020 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current locale breaks UI

4 participants