This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 82.74% 82.82% +0.07%
==========================================
Files 142 142
Lines 1084 1083 -1
Branches 222 210 -12
==========================================
Hits 897 897
Misses 154 154
+ Partials 33 32 -1
|
juanpicado
approved these changes
May 2, 2020
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
👍 all good, but don't merge until other PR are being merged.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
juanpicado
approved these changes
May 17, 2020
juanpicado
added a commit
that referenced
this pull request
May 29, 2020
This reverts commit 4713dea to unblock deployments
juanpicado
added a commit
that referenced
this pull request
May 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See verdaccio/verdaccio#1787