Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

Update zh-CN.json#466

Merged
juanpicado merged 2 commits intoverdaccio:masterfrom
jfthuong:patch-2
May 2, 2020
Merged

Update zh-CN.json#466
juanpicado merged 2 commits intoverdaccio:masterfrom
jfthuong:patch-2

Conversation

@jfthuong
Copy link
Copy Markdown
Contributor

@jfthuong jfthuong commented May 1, 2020

Improve list of languages in Chinese (Simplified) and other misc improvements

Type:

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:

Improve list of languages in Chinese (Simplified) and other misc improvements
@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2020

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         142      142           
  Lines        1077     1077           
  Branches      222      222           
=======================================
  Hits          891      891           
  Misses        153      153           
  Partials       33       33           

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These translations were added recently, I am asking from a point which that I have no clue :-) about the language, what's the difference?

@jfthuong
Copy link
Copy Markdown
Contributor Author

jfthuong commented May 2, 2020

There were few differences

  1. 语 (language) was in traditional characters (which is used for example in Hong Kong) while the rest is using simplified characters (like it is used in mainland China)
  2. "French" was translated as "French (person)" 😂
  3. Sometimes, for language it was using "语" and sometimes "文" (which are almost synonyms). I have made it uniform. Actually, a Chinese friend just helped me check and "语" is more for oral language while "文" is for written language... So all the 语 should be replaced by 文😅

By the way, great devops tools (sonarcloud and codecov)!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@juanpicado
Copy link
Copy Markdown
Member

Thanks again @jfthuong 🚀

@juanpicado juanpicado merged commit f8101ae into verdaccio:master May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants