Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix: revert custom favicon (#463)#480

Merged
juanpicado merged 1 commit intomasterfrom
rollback-463
May 31, 2020
Merged

fix: revert custom favicon (#463)#480
juanpicado merged 1 commit intomasterfrom
rollback-463

Conversation

@juanpicado
Copy link
Copy Markdown
Member

Type: bug

The following has been addressed in the PR:

Description:

This reverts commit 4713dea to unblock deployments

Unfortunately the merge contains a bug, we need to try again

verdaccio/verdaccio#1787 (review)

This reverts commit 4713dea to unblock deployments
@juanpicado
Copy link
Copy Markdown
Member Author

This is my bad, I would have had to test it before merge 😢 , sorry I don't like to undo commits.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juanpicado juanpicado added the bug label May 29, 2020
@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/[email protected] --registry https://registry.verdaccio.org

@juanpicado juanpicado requested a review from anikethsaha May 31, 2020 05:29
@juanpicado juanpicado merged commit 46f76c8 into master May 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the rollback-463 branch May 31, 2020 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants