Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat(lang): Add turkish language#534

Merged
juanpicado merged 2 commits intoverdaccio:masterfrom
tugsanunlu:master
Aug 28, 2020
Merged

feat(lang): Add turkish language#534
juanpicado merged 2 commits intoverdaccio:masterfrom
tugsanunlu:master

Conversation

@tugsanunlu
Copy link
Copy Markdown
Member

Type: Translation

Description: I added Turkish translation requirements for Verdaccio Web User Interface.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tugsanunlu
Copy link
Copy Markdown
Member Author

There are errors in CI. Are these related to my code?

@DanielRuf
Copy link
Copy Markdown
Contributor

Probably not related to your changes. I will trigger a new CI build.

@DanielRuf
Copy link
Copy Markdown
Contributor

DanielRuf commented Aug 28, 2020

Not sure if this is related to the language addition. Could be possible.

Bildschirmfoto 2020-08-28 um 13 23 00

Bildschirmfoto 2020-08-28 um 13 28 46

@DanielRuf
Copy link
Copy Markdown
Contributor

DanielRuf commented Aug 28, 2020

Please use a separate branch in your fork in the future (some branch like add-turkish-language) =)
Because if we push something to our master branch there could be conflicts and this is an anti-pattern.

Bildschirmfoto 2020-08-28 um 13 24 49

@DanielRuf
Copy link
Copy Markdown
Contributor

@juanpicado do you know why this happens? Is this related to the branch name? The errors are not that helpful.

Bildschirmfoto 2020-08-28 um 13 27 05

@tugsanunlu
Copy link
Copy Markdown
Member Author

tugsanunlu commented Aug 28, 2020

Please use a separate branch in your fork in the future (some banch like add-turkish-language) =)r
Because if we push something to our master branch there could be conflicts and this is an anti-pattern.

Bildschirmfoto 2020-08-28 um 13 24 49

I'll pay attention next time. Thanks.

@juanpicado
Copy link
Copy Markdown
Member

@juanpicado do you know why this happens? Is this related to the branch name? The errors are not that helpful.

Bildschirmfoto 2020-08-28 um 13 27 05

fails because forks cannot access to secrets as far I know.

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @tugsanunlu !!! It will be available in the next release

@juanpicado
Copy link
Copy Markdown
Member

juanpicado commented Aug 28, 2020

Please use a separate branch in your fork in the future (some branch like add-turkish-language) =)
Because if we push something to our master branch there could be conflicts and this is an anti-pattern.

Bildschirmfoto 2020-08-28 um 13 24 49

Good advice 👏

@juanpicado juanpicado merged commit 1c43cff into verdaccio:master Aug 28, 2020
@DanielRuf
Copy link
Copy Markdown
Contributor

@juanpicado

fails because forks cannot access to secrets as far I know.

Ah ok, that makes sense. This is one of our own actions? Maybe we should provide a better error / warning.

@juanpicado
Copy link
Copy Markdown
Member

@juanpicado

fails because forks cannot access to secrets as far I know.

Ah ok, that makes sense. This is one of our own actions? Maybe we should provide a better error / warning.

Yes, I think GitHub still does not allows that. What we might do is just filter by branch name and only include local branches.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants