This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat: allow deep links on readme pages#557
Merged
juanpicado merged 1 commit intoverdaccio:masterfrom Oct 16, 2020
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 79.93% 79.82% -0.12%
==========================================
Files 164 164
Lines 1261 1264 +3
Branches 240 241 +1
==========================================
+ Hits 1008 1009 +1
- Misses 215 217 +2
Partials 38 38
|
juanpicado
approved these changes
Oct 16, 2020
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
I verified and this works fine 👍
juanpicado
added
enhancement
Member
|
Thanks @mknj . Great stuff. |
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature
allow deep (aka anchor,i.e. #usage) links in the markdown of readme pages.
The following has been addressed in the PR:
Description:
The underlying markdown Parser already provides header ids in the generated html code for the readme files. Unfortunately these ids are filtered by the xss module. This PR adds a onIgnoreTagAttr helper for h1, h2, ..., h9 ids so that TOC navigation and direct links to paragraphs (i.e. http://localhost:4872/-/web/detail/jquery#including-jquery ) work.