This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat(ui): add prefers-color-scheme media query support#568
Merged
priscilawebdev merged 5 commits intoverdaccio:masterfrom Oct 15, 2020
Merged
feat(ui): add prefers-color-scheme media query support#568priscilawebdev merged 5 commits intoverdaccio:masterfrom
priscilawebdev merged 5 commits intoverdaccio:masterfrom
Conversation
src/design-tokens/ThemeProvider.tsx
Outdated
|
|
||
| const ThemeProvider: React.FC = ({ children }) => { | ||
| const isDarkModeDefault = window?.__VERDACCIO_BASENAME_UI_OPTIONS?.darkMode; | ||
| const prefersDarkMode = window?.matchMedia('(prefers-color-scheme:dark)').matches; |
Contributor
There was a problem hiding this comment.
Suggested change
| const prefersDarkMode = window?.matchMedia('(prefers-color-scheme:dark)').matches; | |
| const prefersDarkMode = window.matchMedia?.('(prefers-color-scheme:dark)').matches; |
after this fix, the tests will pass 😉... Good Job!! 👏
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 79.95% 79.96% +0.01%
==========================================
Files 164 164
Lines 1267 1268 +1
Branches 243 244 +1
==========================================
+ Hits 1013 1014 +1
Misses 216 216
Partials 38 38
|
priscilawebdev
added
the
hacktoberfest-accepted
priscilawebdev
approved these changes
Oct 15, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: Feature
The following has been addressed in the PR: