Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat: restore code splitting with webpack#594

Merged
juanpicado merged 6 commits intomasterfrom
webpack-code-splitting2
Dec 13, 2020
Merged

feat: restore code splitting with webpack#594
juanpicado merged 6 commits intomasterfrom
webpack-code-splitting2

Conversation

@juanpicado
Copy link
Copy Markdown
Member

@juanpicado juanpicado commented Dec 13, 2020

Restore code splitting and improve it. It was broken for a while.

Screenshot from 2020-12-13 09-24-12

➜  static git:(webpack-code-splitting2) tree
.
.
├── 1f07aa4bad48cd09088966736d1ed121.svg
├── 221.35100bd9de813195f301.js
├── 221.35100bd9de813195f301.js.LICENSE.txt
├── 268.79340b38666b01792ae9.css
├── 2939f26c293bff8f35ba87194742aea8.png
├── 454.79340b38666b01792ae9.css
├── 4743f1431b042843890a8644e89bb852.svg
├── 571.35100bd9de813195f301.js
├── 571.35100bd9de813195f301.js.LICENSE.txt
├── 728ff5a8e44d74cd0f2359ef0a9ec88a.png
├── 772.35100bd9de813195f301.js
├── 772.35100bd9de813195f301.js.LICENSE.txt
├── 81ca2d852b9bc86713fe993bf5c7104c.svg
├── 93df1ce974e744e7d98f5d842da74ba0.svg
├── 983328eca26f265748c004651ca0e6c8.svg
├── Dependencies.35100bd9de813195f301.js
├── Dependencies.35100bd9de813195f301.js.LICENSE.txt
├── Dist.35100bd9de813195f301.js
├── Dist.35100bd9de813195f301.js.LICENSE.txt
├── e34a1f287ed2e5ca2d2fa0e0922cddfb.svg
├── Engines.35100bd9de813195f301.js
├── Engines.35100bd9de813195f301.js.LICENSE.txt
├── favicon.ico
├── fonts
│   ├── roboto-latin-100italic.woff
│   ├── roboto-latin-100italic.woff2
│   ├── roboto-latin-100.woff
│   ├── roboto-latin-100.woff2
│   ├── roboto-latin-300italic.woff
│   ├── roboto-latin-300italic.woff2
│   ├── roboto-latin-300.woff
│   ├── roboto-latin-300.woff2
│   ├── roboto-latin-400italic.woff
│   ├── roboto-latin-400italic.woff2
│   ├── roboto-latin-400.woff
│   ├── roboto-latin-400.woff2
│   ├── roboto-latin-500italic.woff
│   ├── roboto-latin-500italic.woff2
│   ├── roboto-latin-500.woff
│   ├── roboto-latin-500.woff2
│   ├── roboto-latin-700italic.woff
│   ├── roboto-latin-700italic.woff2
│   ├── roboto-latin-700.woff
│   ├── roboto-latin-700.woff2
│   ├── roboto-latin-900italic.woff
│   ├── roboto-latin-900italic.woff2
│   ├── roboto-latin-900.woff
│   └── roboto-latin-900.woff2
├── Home.35100bd9de813195f301.js
├── Home.35100bd9de813195f301.js.LICENSE.txt
├── index.html
├── Install.35100bd9de813195f301.js
├── Install.35100bd9de813195f301.js.LICENSE.txt
├── main.1117c41660a6fcfc5e1e.css
├── main.35100bd9de813195f301.js
├── main.35100bd9de813195f301.js.LICENSE.txt
├── NotFound.35100bd9de813195f301.js
├── NotFound.35100bd9de813195f301.js.LICENSE.txt
├── Provider.35100bd9de813195f301.js
├── Provider.35100bd9de813195f301.js.LICENSE.txt
├── Repository.35100bd9de813195f301.js
├── Repository.35100bd9de813195f301.js.LICENSE.txt
├── runtime.35100bd9de813195f301.js
├── runtime.35100bd9de813195f301.js.LICENSE.txt
├── UpLinks.35100bd9de813195f301.js
├── UpLinks.35100bd9de813195f301.js.LICENSE.txt
├── vendors.35100bd9de813195f301.js
├── vendors.35100bd9de813195f301.js.LICENSE.txt
├── Versions.35100bd9de813195f301.js
└── Versions.35100bd9de813195f301.js.LICENSE.txt

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2020

Codecov Report

Merging #594 (d5b8133) into master (0734fde) will decrease coverage by 0.37%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   80.00%   79.62%   -0.38%     
==========================================
  Files         164      165       +1     
  Lines        1275     1286      +11     
  Branches      233      245      +12     
==========================================
+ Hits         1020     1024       +4     
- Misses        218      223       +5     
- Partials       37       39       +2     
Impacted Files Coverage Δ
src/components/Loading/Loading.tsx 100.00% <ø> (ø)
src/App/AppRoute.tsx 86.66% <80.00%> (-6.20%) ⬇️
src/App/utils/loadable.tsx 100.00% <100.00%> (ø)
...Version/DetailContainer/DetailContainerContent.tsx 60.00% <100.00%> (+17.14%) ⬆️
src/pages/Version/DetailSidebar/DetailSidebar.tsx 91.66% <100.00%> (+4.16%) ⬆️
src/utils/file-size.ts 50.00% <0.00%> (-50.00%) ⬇️
src/App/App.tsx 73.68% <0.00%> (-26.32%) ⬇️
...p/Header/RegistryInfoDialog/RegistryInfoDialog.tsx 66.66% <0.00%> (ø)

@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/ui-theme@v1.14.1-d5b8133-pr594.0 --registry https://registry.verdaccio.org

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants