This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat!: manifest over html in production build#610
Merged
juanpicado merged 8 commits intomasterfrom Mar 25, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
=======================================
Coverage 79.39% 79.39%
=======================================
Files 167 167
Lines 1330 1330
Branches 227 227
=======================================
Hits 1056 1056
Misses 232 232
Partials 42 42
|
juanpicado
commented
Mar 24, 2021
tools/webpack.e2e.config.babel.js
Outdated
| @@ -0,0 +1,76 @@ | |||
| const HTMLWebpackPlugin = require('html-webpack-plugin'); | |||
Member
Author
There was a problem hiding this comment.
This is a copy of what we had already.
juanpicado
commented
Mar 24, 2021
package.json
Outdated
| "dev:web": "babel-node tools/dev.server.js", | ||
| "verdaccio:server": "node tools/verdaccio.js", | ||
| "build": "webpack --config tools/webpack.prod.config.babel.js", | ||
| "build:e2e": "webpack --config tools/webpack.e2e.config.babel.js", |
Member
Author
There was a problem hiding this comment.
Only intended for runing e2e
priscilawebdev
approved these changes
Mar 25, 2021
| scope: '', | ||
| version: 'v1.0.0', | ||
| filename: 'index.html', | ||
| verdaccioURL: '//localhost:4873/', |
Contributor
There was a problem hiding this comment.
cool! I always have to change it locally 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type:
The following has been addressed in the PR:
Description:
<scripts/>url using behind a proxy. Part of fix: url_prefix behaviour verdaccio#2122It does not ship the
index.htmlwith the published package, just a webpack manifest file that is interpreted by the backend.v4.1.13.