Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

fix: inject css files to the dom as style#612

Merged
juanpicado merged 1 commit intomasterfrom
fix-css-issue
Apr 8, 2021
Merged

fix: inject css files to the dom as style#612
juanpicado merged 1 commit intomasterfrom
fix-css-issue

Conversation

@juanpicado
Copy link
Copy Markdown
Member

@juanpicado juanpicado commented Apr 7, 2021

Fix issue on Verdaccio 5 , the markdown overflow the detail, the reason was that webpack was not including the css files with the style-loader.

Here you can see the broken layout.
https://registry.verdaccio.org/-/web/detail/verdaccio

@juanpicado juanpicado requested review from a team and priscilawebdev April 7, 2021 21:14
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2021

Codecov Report

Merging #612 (1710e68) into master (fb939c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files         167      167           
  Lines        1330     1330           
  Branches      227      227           
=======================================
  Hits         1056     1056           
  Misses        232      232           
  Partials       42       42           

@juanpicado juanpicado merged commit 6de7ccf into master Apr 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-css-issue branch April 8, 2021 19:46
@juanpicado
Copy link
Copy Markdown
Member Author

I merge, need to release this, there is a bug need to fix before release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant