From 3911b16b9c996a6c11ac098b59122f53fa367b84 Mon Sep 17 00:00:00 2001 From: Ayush Sharma Date: Sun, 28 Apr 2019 10:34:12 +0200 Subject: [PATCH 1/3] fix: object passing for react rendering --- src/webui/components/Versions/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/webui/components/Versions/index.js b/src/webui/components/Versions/index.js index 73496cf0a..df284c782 100644 --- a/src/webui/components/Versions/index.js +++ b/src/webui/components/Versions/index.js @@ -32,7 +32,8 @@ class Versions extends React.PureComponent { {version} - {isVersion && timeMap[version] ? `${formatDateDistance(timeMap[version])} ago` : packages[version]} + {isVersion && {timeMap[version] ? `${formatDateDistance(timeMap[version])} ago` : 'Not available'}} + {isVersion === false && {packages[version]}} ))} From 05aacd6e3cebe470a761e92e36c25f356e111e83 Mon Sep 17 00:00:00 2001 From: Ayush Sharma Date: Sun, 28 Apr 2019 11:31:41 +0200 Subject: [PATCH 2/3] fix: const for 'not available' --- src/webui/components/Versions/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/webui/components/Versions/index.js b/src/webui/components/Versions/index.js index df284c782..cc225c63b 100644 --- a/src/webui/components/Versions/index.js +++ b/src/webui/components/Versions/index.js @@ -24,6 +24,7 @@ class Versions extends React.PureComponent { } renderPackageList = (packages: any, isVersion: boolean = false, timeMap: Object = {}) => { + const notAvailable = 'Not available'; return ( {Object.keys(packages) @@ -32,7 +33,7 @@ class Versions extends React.PureComponent { {version} - {isVersion && {timeMap[version] ? `${formatDateDistance(timeMap[version])} ago` : 'Not available'}} + {isVersion && {timeMap[version] ? `${formatDateDistance(timeMap[version])} ago` : notAvailable}} {isVersion === false && {packages[version]}} ))} From 7e24f23a6dcb4876e18ee68ee3834f81a5a82628 Mon Sep 17 00:00:00 2001 From: Ayush Sharma Date: Sun, 28 Apr 2019 11:57:34 +0200 Subject: [PATCH 3/3] fix: const for 'not available' --- src/webui/components/Versions/index.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/webui/components/Versions/index.js b/src/webui/components/Versions/index.js index cc225c63b..da036e75a 100644 --- a/src/webui/components/Versions/index.js +++ b/src/webui/components/Versions/index.js @@ -11,6 +11,8 @@ import ListItem from '@material-ui/core/ListItem/index'; import React from 'react'; import { DIST_TAGS } from '../../../lib/constants'; +const NOT_AVAILABLE = 'Not available'; + class Versions extends React.PureComponent { render() { return ( @@ -24,7 +26,6 @@ class Versions extends React.PureComponent { } renderPackageList = (packages: any, isVersion: boolean = false, timeMap: Object = {}) => { - const notAvailable = 'Not available'; return ( {Object.keys(packages) @@ -33,7 +34,7 @@ class Versions extends React.PureComponent { {version} - {isVersion && {timeMap[version] ? `${formatDateDistance(timeMap[version])} ago` : notAvailable}} + {isVersion && {timeMap[version] ? `${formatDateDistance(timeMap[version])} ago` : NOT_AVAILABLE}} {isVersion === false && {packages[version]}} ))}