Skip to content

Commit dd585b9

Browse files
committed
fix: replace NovaWindows automation name with DesktopDriver
1 parent 3acee1c commit dd585b9

File tree

6 files changed

+27
-24
lines changed

6 files changed

+27
-24
lines changed
Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,42 @@
11
name: Claude Code Review
22

33
on:
4-
issue_comment:
5-
types: [created]
4+
pull_request:
5+
types: [opened]
6+
branches: [main]
67

78
jobs:
89
claude-review:
9-
# Only run when an owner/member comments "/review" on a PR
10-
if: |
11-
github.event.issue.pull_request != null &&
12-
contains(github.event.comment.body, '/review') &&
13-
(
14-
github.event.comment.author_association == 'OWNER' ||
15-
github.event.comment.author_association == 'MEMBER' ||
16-
github.event.comment.author_association == 'COLLABORATOR'
17-
)
18-
1910
runs-on: ubuntu-latest
2011
permissions:
2112
contents: read
2213
pull-requests: write
2314
issues: write
2415
id-token: write
16+
actions: read
2517

2618
steps:
2719
- name: Checkout repository
2820
uses: actions/checkout@v4
2921
with:
3022
fetch-depth: 1
3123

24+
- name: Load review guide
25+
id: review-guide
26+
run: echo "REVIEW_GUIDE<<EOF" >> $GITHUB_OUTPUT && cat .github/claude-review-guide.md >> $GITHUB_OUTPUT && echo "EOF" >> $GITHUB_OUTPUT
27+
3228
- name: Run Claude Code Review
3329
id: claude-review
3430
uses: anthropics/claude-code-action@v1
3531
with:
3632
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
37-
plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
38-
plugins: 'code-review@claude-code-plugins'
39-
prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.issue.number }}'
33+
additional_permissions: |
34+
actions: read
35+
prompt: |
36+
Please review the changes in pull request #${{ github.event.pull_request.number }} in this repository.
37+
Use the `gh` CLI to fetch the PR diff and details.
38+
Follow these project-specific review guidelines:
39+
40+
${{ steps.review-guide.outputs.REVIEW_GUIDE }}
41+
42+
Post your review as a PR review with inline comments where applicable using `gh pr review`.

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ All driver commands live in `lib/commands/` and are mixed into the driver class
5757

5858
## Key capabilities
5959

60-
- `platformName`: `"Windows"`, `automationName`: `"NovaWindows"`
60+
- `platformName`: `"Windows"`, `automationName`: `"DesktopDriver"`
6161
- Supported locator strategies: `xpath`, `accessibility id`, `id`, `name`, `class name`, `tag name`, `-windows uiautomation`
6262
- Custom `executeScript()` commands listed in README.md
6363
- Prerun/postrun PowerShell scripts via session capabilities

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ NovaWindows Driver supports the following capabilities:
3737
Capability Name | Description
3838
--- | ---
3939
platformName | Must be set to `Windows` (case-insensitive).
40-
automationName | Must be set to `NovaWindows` (case-insensitive).
40+
automationName | Must be set to `DesktopDriver` (case-insensitive).
4141
smoothPointerMove | CSS-like easing function (including valid Bezier curve). This controls the smooth movement of the mouse for `delayBeforeClick` ms. Example: `ease-in`, `cubic-bezier(0.42, 0, 0.58, 1)`.
4242
delayBeforeClick | Time in milliseconds before a click is performed.
4343
delayAfterClick | Time in milliseconds after a click is performed.

examples/C#/CalculatorTest/CalculatorTest/CalculatorSession.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ protected static void Setup()
2222
var appiumOptions = new AppiumOptions
2323
{
2424
App = CalculatorAppId,
25-
AutomationName = "NovaWindows",
25+
AutomationName = "DesktopDriver",
2626
PlatformName = "Windows",
2727
};
2828

@@ -41,4 +41,4 @@ protected static void TearDown()
4141
Session.Quit();
4242
Session = null;
4343
}
44-
}
44+
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"platformNames": [
4545
"Windows"
4646
],
47-
"mainClass": "DesktopDriver"
47+
"mainClass": "NovaWindowsDriver"
4848
},
4949
"devDependencies": {
5050
"@appium/eslint-config-appium-ts": "^2.0.3",

test/e2e/helpers/session.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export async function createCalculatorSession(extraCaps?: Record<string, unknown
1919
...APPIUM_SERVER,
2020
capabilities: {
2121
platformName: 'Windows',
22-
'appium:automationName': 'NovaWindows',
22+
'appium:automationName': 'DesktopDriver',
2323
'appium:app': CALCULATOR_APP_ID,
2424
...extraCaps,
2525
} as Caps,
@@ -33,7 +33,7 @@ export async function createNotepadSession(extraCaps?: Record<string, unknown>):
3333
...APPIUM_SERVER,
3434
capabilities: {
3535
platformName: 'Windows',
36-
'appium:automationName': 'NovaWindows',
36+
'appium:automationName': 'DesktopDriver',
3737
'appium:app': NOTEPAD_APP_PATH,
3838
...extraCaps,
3939
} as Caps,
@@ -47,7 +47,7 @@ export async function createTodoSession(extraCaps?: Record<string, unknown>): Pr
4747
...APPIUM_SERVER,
4848
capabilities: {
4949
platformName: 'Windows',
50-
'appium:automationName': 'NovaWindows',
50+
'appium:automationName': 'DesktopDriver',
5151
'appium:app': TODO_APP_ID,
5252
...extraCaps,
5353
} as Caps,
@@ -61,7 +61,7 @@ export async function createRootSession(extraCaps?: Record<string, unknown>): Pr
6161
...APPIUM_SERVER,
6262
capabilities: {
6363
platformName: 'Windows',
64-
'appium:automationName': 'NovaWindows',
64+
'appium:automationName': 'DesktopDriver',
6565
'appium:app': 'Root',
6666
...extraCaps,
6767
} as Caps,

0 commit comments

Comments
 (0)