Merge pull request #2 from vintasoftware/feat/additional-backends

Additional backends

Author: hugobessa

package.json

@@ -1,6 +1,6 @@
 {
   "name": "vintasend-medplum",
-  "version": "0.7.1",
+  "version": "0.8.1",
   "description": "",
   "main": "dist/index.js",
   "scripts": {
@@ -25,7 +25,7 @@
     "@medplum/fhirtypes": "^5.0.10",
     "pdfmake": "^0.2.23",
     "pug": "^3.0.3",
-    "vintasend": "^0.7.1"
+    "vintasend": "^0.8.1"
   },
   "devDependencies": {
     "@medplum/definitions": "^5.0.10",

src/__tests__/medplum-adapter-attachments.test.ts

@@ -29,6 +29,7 @@ describe('MedplumNotificationAdapter - Attachments', () => {
 
     mockTemplateRenderer = {
       render: jest.fn(),
+      renderFromTemplateContent: jest.fn(),
     } as jest.Mocked<BaseEmailTemplateRenderer<any>>;
 
     mockBackend = {

src/__tests__/medplum-adapter-one-off.test.ts

@@ -30,6 +30,7 @@ describe('MedplumNotificationAdapter - One-Off Notifications', () => {
 
     mockTemplateRenderer = {
       render: jest.fn(),
+      renderFromTemplateContent: jest.fn(),
     } as jest.Mocked<BaseEmailTemplateRenderer<any>>;
 
     mockBackend = {

src/__tests__/medplum-adapter.test.ts

@@ -27,6 +27,7 @@ describe('MedplumNotificationAdapter', () => {
 
     mockTemplateRenderer = {
       render: jest.fn(),
+      renderFromTemplateContent: jest.fn(),
     } as jest.Mocked<BaseEmailTemplateRenderer<any>>;
 
     mockBackend = {

src/__tests__/medplum-backend.test.ts

@@ -122,6 +122,33 @@ describe('MedplumNotificationBackend', () => {
       });
     });
 
+    it('should persist notification with predefined id when provided', async () => {
+      const predefinedId = 'predefined-medplum-notification-id';
+      const input = {
+        id: predefinedId,
+        userId: 'user-123',
+        notificationType: 'EMAIL' as const,
+        bodyTemplate: 'Test Body',
+        contextName: 'testContext' as keyof TestConfig['ContextMap'],
+        contextParameters: { param1: 'value1' },
+        title: 'Test Title',
+        subjectTemplate: 'Test Subject',
+        extraParams: { key: 'value' },
+        sendAfter: null,
+      };
+
+      const createResourceSpy = jest.spyOn(medplumClient, 'createResource');
+      const result = await backend.persistNotification(input);
+
+      expect(createResourceSpy).toHaveBeenCalledWith(
+        expect.objectContaining({
+          resourceType: 'Communication',
+          id: predefinedId,
+        }),
+      );
+      expect(result.id).toBe(predefinedId);
+    });
+
     it('should handle sendAfter date by setting sent extension', async () => {
       const sendAfter = new Date('2026-02-01T00:00:00Z');
       const input = {

src/medplum-backend.ts

@@ -32,6 +32,7 @@ import type { MedplumStorageIdentifiers } from './types';
 
 type MedplumNotificationBackendOptions = {
   emailNotificationSubjectExtensionUrl?: string;
+  identifier?: string;
 };
 
 type StringFilterLookup = {
@@ -57,10 +58,18 @@ const IDENTIFIER_SYSTEMS = {
 export class MedplumNotificationBackend<Config extends BaseNotificationTypeConfig> implements BaseNotificationBackend<Config> {
   private attachmentManager?: BaseAttachmentManager;
   private logger?: BaseLogger;
+  private identifier: string;
 
   constructor(private medplum: MedplumClient, private options: MedplumNotificationBackendOptions = {
     emailNotificationSubjectExtensionUrl: 'http://vintasend.com/fhir/StructureDefinition/email-notification-subject',
-  }) {}
+    identifier: 'default-medplum',
+  }) {
+    this.identifier = options.identifier || 'default-medplum';
+  }
+
+  getBackendIdentifier(): string {
+    return this.identifier;
+  }
 
   /**
    * Inject attachment manager (called by VintaSend when both service and backend exist)
@@ -304,7 +313,9 @@ export class MedplumNotificationBackend<Config extends BaseNotificationTypeConfi
       .filter((n): n is DatabaseNotification<Config> => 'userId' in n);
   }
 
-  async persistNotification(notification: NotificationInput<Config>): Promise<DatabaseNotification<Config>> {
+  async persistNotification(
+    notification: Omit<Notification<Config>, 'id'> & { id?: Config['NotificationIdType'] },
+  ): Promise<DatabaseNotification<Config>> {
     const notificationWithOptionalGitCommitSha = notification as NotificationInput<Config> & {
       gitCommitSha?: string | null;
     };
@@ -344,6 +355,7 @@ export class MedplumNotificationBackend<Config extends BaseNotificationTypeConfi
 
     const communication: Communication = {
       resourceType: 'Communication',
+      ...(notification.id ? { id: notification.id as string } : {}),
       status: 'in-progress',
       sent: notification.sendAfter?.toISOString(),
       topic: { text: notification.title || undefined },
@@ -705,7 +717,9 @@ export class MedplumNotificationBackend<Config extends BaseNotificationTypeConfi
   /* One-off notification methods */
 
   async persistOneOffNotification(
-    notification: Omit<OneOffNotificationInput<Config>, 'id'>,
+    notification: Omit<OneOffNotificationInput<Config>, 'id'> & {
+      id?: Config['NotificationIdType'];
+    },
   ): Promise<DatabaseOneOffNotification<Config>> {
     const notificationWithOptionalGitCommitSha = notification as Omit<
       OneOffNotificationInput<Config>,
@@ -749,6 +763,7 @@ export class MedplumNotificationBackend<Config extends BaseNotificationTypeConfi
 
     const communication: Communication = {
       resourceType: 'Communication',
+      ...(notification.id ? { id: notification.id as string } : {}),
       status: 'in-progress',
       sent: notification.sendAfter?.toISOString(),
       topic: { text: notification.title || undefined },
@@ -1691,7 +1706,7 @@ export class MedplumNotificationBackend<Config extends BaseNotificationTypeConfi
 }
 
 export class MedplumNotificationBackendFactory<Config extends BaseNotificationTypeConfig> {
-  create(medplum: MedplumClient) {
-    return new MedplumNotificationBackend<Config>(medplum);
+  create(medplum: MedplumClient, options?: MedplumNotificationBackendOptions) {
+    return new MedplumNotificationBackend<Config>(medplum, options);
   }
 }