Skip to content

Fix bvlshr name and add a test.#537

Merged
vakaras merged 3 commits into
masterfrom
floats-shr
Jul 30, 2021
Merged

Fix bvlshr name and add a test.#537
vakaras merged 3 commits into
masterfrom
floats-shr

Conversation

@vakaras

@vakaras vakaras commented Jul 30, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@vakaras vakaras requested a review from marcoeilers July 30, 2021 10:54
Comment thread src/main/scala/viper/silver/ast/utility/BackendTypeFactories.scala
@marcoeilers

Copy link
Copy Markdown
Contributor

LGTM! We might want to add either a single link to the SMTLIB description of these functions or, if we're adding functions that aren't in that description for some reason (I didn't see bvashr either), maybe we should just add a comment per function that describes what it does.

@vakaras

vakaras commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

LGTM! We might want to add either a single link to the SMTLIB description of these functions or, if we're adding functions that aren't in that description for some reason (I didn't see bvashr either), maybe we should just add a comment per function that describes what it does.

@Aurel300 Is there a specific document in which you found bvashr? I found the functions I added here.

@Aurel300

Copy link
Copy Markdown
Member

@Aurel300 Is there a specific document in which you found bvashr? I found the functions I added here.

The function itself is mentioned in the guide. In the text above there is a dead link, but it is preserved on the web archive—maybe this is what the source was? There is also the source code. The documentation for Z3 is pretty bad…

@vakaras

vakaras commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

The SMT and Z3 documentations are really amazing. I assume that Z3 supports a union of the mentioned functions…

@vakaras vakaras merged commit d6461e9 into master Jul 30, 2021
@vakaras

vakaras commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

@ArquintL Will the IDE CI automatically pick up this change, or do I need to do anything special?

@vakaras vakaras deleted the floats-shr branch July 30, 2021 13:13
@ArquintL

Copy link
Copy Markdown
Member

@ArquintL Will the IDE CI automatically pick up this change, or do I need to do anything special?

ViperServer repo should identify this commit tomorrow morning and in turn trigger a new nightly build of the ViperTools in the Viper-IDE repo

@vakaras

vakaras commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

@ArquintL Will the IDE CI automatically pick up this change, or do I need to do anything special?

ViperServer repo should identify this commit tomorrow morning and in turn trigger a new nightly build of the ViperTools in the Viper-IDE repo

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants