Change to beginner mode

Author: JonasAlaif

src/main/scala/viper/server/ViperConfig.scala

@@ -53,8 +53,8 @@ class ViperConfig(args: Seq[String]) extends ScallopConf(args) {
     hidden = false
   )
 
-  val presentationMode: ScallopOption[Boolean] = opt[Boolean]("presentationMode",
-    descr = "Enables presentation mode, which disables most LSP features (those that are distracting in presentations).",
+  val beginnerMode: ScallopOption[Boolean] = opt[Boolean]("beginnerMode",
+    descr = "Enables beginner mode, which disables some advanced features that can be confusing for new users.",
     default = Some(false),
     noshort = true,
     hidden = false

src/main/scala/viper/server/frontends/lsp/Receiver.scala

@@ -30,8 +30,7 @@ trait StandardReceiver {
 trait LanguageReceiver extends StandardReceiver with LanguageServer {
 
   override def initialize(params: InitializeParams): CompletableFuture[InitializeResult] = {
-    val presentationMode = coordinator.server.config.presentationMode()
-    coordinator.logger.debug(s"[Req: initialize] ${params.toString()} (presentation mode: $presentationMode)")
+    coordinator.logger.debug(s"[Req: initialize] ${params.toString()}")
     val capabilities = new ServerCapabilities()
     capabilities.setTextDocumentSync(TextDocumentSyncKind.Incremental)
     // Features https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#languageFeatures
@@ -53,9 +52,9 @@ trait LanguageReceiver extends StandardReceiver with LanguageServer {
     // Document Link (disabled Resolve):
     capabilities.setDocumentLinkProvider(new DocumentLinkOptions(false))
     // Hover:
-    if (!presentationMode) capabilities.setHoverProvider(true)
+    capabilities.setHoverProvider(true)
     // Code Lens (disabled Resolve):
-    if (!presentationMode) capabilities.setCodeLensProvider(new CodeLensOptions(false))
+    capabilities.setCodeLensProvider(new CodeLensOptions(false))
     // Folding Range:
     capabilities.setFoldingRangeProvider(true)
     // Selection Range:         [N/A]
@@ -78,15 +77,15 @@ trait LanguageReceiver extends StandardReceiver with LanguageServer {
     capabilities.setSemanticTokensProvider(new SemanticTokensWithRegistrationOptions(legend, true))
     // Inline Value:            [N/A]
     // Inlay Hint (disabled Resolve):
-    if (!presentationMode) capabilities.setInlayHintProvider(true)
+    capabilities.setInlayHintProvider(true)
     // Moniker:                 [N/A]
     // Completion Proposals:
-    if (!presentationMode) capabilities.setCompletionProvider(new CompletionOptions(false, Seq(".", ":", "(", "[", "{").asJava))
+    capabilities.setCompletionProvider(new CompletionOptions(false, Seq(".", ":", "(", "[", "{").asJava))
     // Pull Diagnostics:        DISABLED (we use `publishDiagnostics` instead)
     // capabilities.setDiagnosticProvider(new DiagnosticRegistrationOptions(true, false))
     // Signature Help:
     // Allow a `,` to try and restart the signature help even after it has ended
-    if (!presentationMode) capabilities.setSignatureHelpProvider(new SignatureHelpOptions(Seq("(", ",").asJava, Seq().asJava))
+    capabilities.setSignatureHelpProvider(new SignatureHelpOptions(Seq("(", ",").asJava, Seq().asJava))
     // Code Action:
     capabilities.setCodeActionProvider(true)
     // Document Color:          [N/A]

src/main/scala/viper/server/frontends/lsp/ast/ParseAstLsp.scala

@@ -64,8 +64,8 @@ object HasFoldingRanges {
 }
 
 object HasInlayHints {
-  def apply(p: PProgram): Seq[InlayHint] = p.deepCollect({
-    case n: PCall => PLspCall.getInlayHints(n)
+  def apply(p: PProgram, beginnerMode: Boolean): Seq[InlayHint] = p.deepCollect({
+    case n: PCall if !beginnerMode => PLspCall.getInlayHints(n)
     case n: PLet => PLspLet.getInlayHints(n)
   }).flatten
 }

src/main/scala/viper/server/frontends/lsp/file/RelayActor.scala

@@ -129,13 +129,14 @@ class RelayActor(task: MessageHandler, backendClassName: Option[String]) extends
         task.resetContainers(true)
         task.lastPhase = Some(phase)
 
+        val beginnerMode = coordinator.server.config.beginnerMode()
         task.addCodeLens(true)(HasCodeLens(pProgram))
         task.addDocumentSymbol(true)(HasDocumentSymbol(pProgram).toSeq)
         task.addHoverHint(true)(HasHoverHints(pProgram))
         task.addGotoDefinition(true)(HasGotoDefinitions(pProgram))
         task.addFindReferences(true)(HasReferenceTos(pProgram))
         task.addFoldingRange(true)(HasFoldingRanges(pProgram))
-        task.addInlayHint(true)(HasInlayHints(pProgram))
+        task.addInlayHint(true)(HasInlayHints(pProgram, beginnerMode))
         task.addSemanticHighlight(true)(HasSemanticHighlights(pProgram))
         task.addSignatureHelp(true)(HasSignatureHelps(pProgram))
         task.addSuggestionScopeRange(true)(HasSuggestionScopeRanges(pProgram))