fix!: do not fixStacktrace by default (#7995)

benmccann · web-flow · commit 23f8e08fd568 · 2022-05-23T07:30:28.000+02:00
diff --git a/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts
@@ -13,7 +13,7 @@ test('always throw error when evaluating an wrong SSR module', async () => {
   const expectedErrors = []
   for (const _ of [0, 1]) {
     try {
-      await viteServer.ssrLoadModule(badjs)
+      await viteServer.ssrLoadModule(badjs, { fixStacktrace: true })
     } catch (e) {
       expectedErrors.push(e)
     }
diff --git a/packages/vite/src/node/ssr/ssrModuleLoader.ts b/packages/vite/src/node/ssr/ssrModuleLoader.ts
@@ -206,7 +206,7 @@ async function instantiateModule(
     )
   } catch (e) {
     mod.ssrError = e
-    if (e.stack && fixStacktrace !== false) {
+    if (e.stack && fixStacktrace) {
       const stacktrace = ssrRewriteStacktrace(e.stack, moduleGraph)
       rebindErrorStacktrace(e, stacktrace)
       server.config.logger.error(

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ test('always throw error when evaluating an wrong SSR module', async () => {`
`13`	`13`	`const expectedErrors = []`
`14`	`14`	`for (const _ of [0, 1]) {`
`15`	`15`	`try {`
`16`		`- await viteServer.ssrLoadModule(badjs)`
	`16`	`+ await viteServer.ssrLoadModule(badjs, { fixStacktrace: true })`
`17`	`17`	`} catch (e) {`
`18`	`18`	`expectedErrors.push(e)`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ async function instantiateModule(`
`206`	`206`	`)`
`207`	`207`	`} catch (e) {`
`208`	`208`	`mod.ssrError = e`
`209`		`- if (e.stack && fixStacktrace !== false) {`
	`209`	`+ if (e.stack && fixStacktrace) {`
`210`	`210`	`const stacktrace = ssrRewriteStacktrace(e.stack, moduleGraph)`
`211`	`211`	`rebindErrorStacktrace(e, stacktrace)`
`212`	`212`	`server.config.logger.error(`