fix(ssr): class property keys hoisting matching imports (#22199)

Author: SunsetFi

packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts

@@ -860,25 +860,35 @@ test('class props', async () => {
   expect(
     await ssrTransformSimpleCode(
       `
-import { remove, add } from 'vue'
+import { remove, add, update, del, call } from 'vue'
 
 class A {
   remove = 1
   add = null
+  update = update
+  del = () => del()
+  call = call(4)
 }
+
+remove(2);
+add(4);
 `,
     ),
   ).toMatchInlineSnapshot(`
-    "const __vite_ssr_import_0__ = await __vite_ssr_import__("vue", {"importedNames":["remove","add"]});
+    "const __vite_ssr_import_0__ = await __vite_ssr_import__("vue", {"importedNames":["remove","add","update","del","call"]});
 
 
 
-    const add = __vite_ssr_import_0__.add;
-    const remove = __vite_ssr_import_0__.remove;
     class A {
       remove = 1
       add = null
+      update = __vite_ssr_import_0__.update
+      del = () => (0,__vite_ssr_import_0__.del)()
+      call = (0,__vite_ssr_import_0__.call)(4)
     }
+
+    (0,__vite_ssr_import_0__.remove)(2);
+    (0,__vite_ssr_import_0__.add)(4);
     "
   `)
 })

packages/vite/src/node/ssr/ssrTransform.ts

@@ -344,7 +344,6 @@ async function ssrTransformScript(
       }
     },
     onIdentifier(id, parent, parentStack) {
-      const grandparent = parentStack[1]
       const binding = idToImportMap.get(id.name)
       if (!binding) {
         return
@@ -360,9 +359,8 @@ async function ssrTransformScript(
           s.appendLeft(id.end, `: ${binding}`)
         }
       } else if (
-        (parent.type === 'PropertyDefinition' &&
-          grandparent?.type === 'ClassBody') ||
-        (parent.type === 'ClassDeclaration' && id === parent.superClass)
+        parent.type === 'ClassDeclaration' &&
+        id === parent.superClass
       ) {
         if (!declaredConst.has(id.name)) {
           declaredConst.add(id.name)
@@ -680,6 +678,13 @@ function isRefIdentifier(
     return false
   }
 
+  // class property key
+  if (parent.type === 'PropertyDefinition' && !parent.computed) {
+    // values can still contain identifier references,
+    // but keys cannot unless computed.
+    return parent.value === id
+  }
+
   // property key
   if (isStaticPropertyKey(id, parent)) {
     return false