Skip to content

chore(create-vite): remove sourcemap, move --noEmit to tsconfig#10150

Merged
patak-cat merged 1 commit intovitejs:mainfrom
lvqq:main
Sep 18, 2022
Merged

chore(create-vite): remove sourcemap, move --noEmit to tsconfig#10150
patak-cat merged 1 commit intovitejs:mainfrom
lvqq:main

Conversation

@lvqq
Copy link
Copy Markdown
Contributor

@lvqq lvqq commented Sep 17, 2022

Description

remove unnecessary soucemap in ts templates and move --noEmit to tsconfig in vue-ts template to make it consistent with other templates

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-cat patak-cat added the p1-chore Doesn't change code behavior (priority) label Sep 17, 2022
@patak-cat patak-cat changed the title fix: remove soucemap and move --noEmit to tsconfig in ts templates chore(create-vite): remove sourcemap, move --noEmit to tsconfig Sep 18, 2022
@patak-cat patak-cat merged commit 414d2ef into vitejs:main Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants