Skip to content

chore(create-vite): update volar link in helloworld components#12145

Merged
bluwy merged 3 commits intovitejs:mainfrom
shayneo:chore/volar-links-hello-world
Feb 25, 2023
Merged

chore(create-vite): update volar link in helloworld components#12145
bluwy merged 3 commits intovitejs:mainfrom
shayneo:chore/volar-links-hello-world

Conversation

@shayneo
Copy link
Copy Markdown
Contributor

@shayneo shayneo commented Feb 22, 2023

Description

Updates volar links in vue create-vite components

Additional context

Continues on the efforts of these PRs
#7994
#11128


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Comment thread packages/create-vite/template-vue-ts/src/components/HelloWorld.vue Outdated
<p>
Install
<a href="https://github.com/johnsoncodehk/volar" target="_blank">Volar</a>
<a href="https://github.com/vuejs/language-tools" target="_blank">Volar</a>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed it back to Volar to keep with the naming in create-vue for now. I think it's more recognizable too.

@bluwy bluwy changed the title chore: update volar link in helloworld components chore(create-vite): update volar link in helloworld components Feb 25, 2023
@bluwy bluwy merged commit 7110ddf into vitejs:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants