feat(create-vite): use typescript 5.0 in templates#12481
Merged
patak-cat merged 11 commits intovitejs:mainfrom Mar 30, 2023
Merged
feat(create-vite): use typescript 5.0 in templates#12481patak-cat merged 11 commits intovitejs:mainfrom
patak-cat merged 11 commits intovitejs:mainfrom
Conversation
`--forceConsistentCasingInFileNames` is no longer necessary
|
|
This comment was marked as resolved.
This comment was marked as resolved.
fi3ework
reviewed
Mar 19, 2023
Member
There was a problem hiding this comment.
AFAIK, the tsconfig in vite package could not use moduleResolution: "bundler" for these reasons:
ufodoes not ship atypesfield inexports, they had added it https://github.com/unjs/ufo/blob/main/package.json#L10 and I believe it gonna be published in days.@ampproject/remappingrelies on an old version of@jridgewell/gen-mappingwhich does not provide correctexports.types. The source code has been updated but not published. I filed an issue to track this ampproject/remapping#184api-extractorsomehow seems like do not recognizebundlerfor now and will throw an error.
fi3ework
reviewed
Mar 20, 2023
ArnaudBarre
previously approved these changes
Mar 26, 2023
patak-cat
previously approved these changes
Mar 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TypeScript 5.0 has been released with standard decorator support and various config improvements, notably including
--moduleResolution bundlerwhich is recommended by Evan You and Daniel Rosenwasser for Vite users.Additional context
Note that due to TypeScript not following semver, 4.9 and 5.0 are both releases with breaking changes, so this upgrade should be roughly as compatible as previous major and minor upgrades.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).